Skip to content

Clicking a notification marks it as read but doesn't remove it from the app #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
adufr opened this issue Feb 18, 2024 · 1 comment · Fixed by #789
Closed
1 task done

Clicking a notification marks it as read but doesn't remove it from the app #785

adufr opened this issue Feb 18, 2024 · 1 comment · Fixed by #789
Labels
bug Something isn't working

Comments

@adufr
Copy link
Contributor

adufr commented Feb 18, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

Using the main branch, when you click on a notification it automatically gets marked as read, but Gitify doesn't remove the notification until the 60s setInterval gets triggered again

Should we remove the notification on click?

🪜 Steps To Reproduce

  1. Build & run the app from the main branch
  2. Click on a notification
  3. Wait for the next notifications refresh -> the notification disappears

ℹ System Info

`main` branch

📸 Screenshots

No response

@adufr adufr added the bug Something isn't working label Feb 18, 2024
@setchy
Copy link
Member

setchy commented Feb 18, 2024

Good catch. Yes, I think we should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants