Simplify building and testing the Go components

Author: Nick Thomas

Makefile

@@ -1,6 +1,6 @@
 .PHONY: validate verify verify_ruby verify_golang test test_ruby test_golang setup _install build compile check clean
 
-GO_SOURCES := $(shell find go -name '*.go')
+GO_SOURCES := $(shell find . -name '*.go')
 
 validate: verify test
 
@@ -10,7 +10,7 @@ verify_ruby:
 	bundle exec rubocop
 
 verify_golang:
-	support/go-format check
+	gofmt -s -l $(GO_SOURCES)
 
 test: test_ruby test_golang
 
@@ -19,7 +19,7 @@ test_ruby:
 	bundle exec rspec --color --format d spec
 
 test_golang:
-	support/go-test
+	go test ./...
 
 setup: _install bin/gitlab-shell
 
@@ -29,10 +29,10 @@ _install:
 build: bin/gitlab-shell
 compile: bin/gitlab-shell
 bin/gitlab-shell: $(GO_SOURCES)
-	bin/compile
+	GOBIN="$(CURDIR)/bin" go install ./cmd/...
 
 check:
 	bin/check
 
 clean:
-	rm -f bin/gitlab-shell bin/gitlab-shell-authorized-keys-check bin/gitlab-shell-authorized-principals-check
+	rm -f bin/check bin/gitlab-shell bin/gitlab-shell-authorized-keys-check bin/gitlab-shell-authorized-principals-check

bin/compile

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
 
 # Load ROOT_PATH and access the minimum necessary config file
-require_relative '../support/go_build'
 require_relative '../support/gitlab_config'
 
 config = GitlabConfig.new

bin/install

@@ -1,16 +1,14 @@
-module gitlab.com/gitlab-org/gitlab-shell/go
+module gitlab.com/gitlab-org/gitlab-shell
 
 go 1.12
 
 require (
 	github.com/mattn/go-shellwords v0.0.0-20190425161501-2444a32a19f4
 	github.com/otiai10/copy v1.0.1
-	github.com/otiai10/curr v0.0.0-20190513014714-f5a3d24e5776 // indirect
 	github.com/sirupsen/logrus v1.2.0
 	github.com/stretchr/testify v1.3.0
 	gitlab.com/gitlab-org/gitaly v1.68.0
 	gitlab.com/gitlab-org/labkit v0.0.0-20190221122536-0c3fc7cdd57c
 	google.golang.org/grpc v1.24.0
-	gopkg.in/DataDog/dd-trace-go.v1 v1.9.0 // indirect
 	gopkg.in/yaml.v2 v2.2.2
 )

go.mod

@@ -1,5 +1,8 @@
 require 'yaml'
 
+# Determine the root of the gitlab-shell directory
+ROOT_PATH = ENV.fetch('GITLAB_SHELL_DIR', File.expand_path('..', __dir__))
+
 class GitlabConfig
   attr_reader :config