[ws-manager] do not error out if encountering unknown feature flag

sagor999 · roboquat · commit 07af344487ae · 2022-08-30T20:45:15.000+02:00
diff --git a/components/ws-manager/pkg/manager/create.go b/components/ws-manager/pkg/manager/create.go
@@ -30,6 +30,7 @@ import (
 
 	"github.com/gitpod-io/gitpod/common-go/kubernetes"
 	wsk8s "github.com/gitpod-io/gitpod/common-go/kubernetes"
+	"github.com/gitpod-io/gitpod/common-go/log"
 	"github.com/gitpod-io/gitpod/common-go/tracing"
 	"github.com/gitpod-io/gitpod/common-go/util"
 	csapi "github.com/gitpod-io/gitpod/content-service/api"
@@ -626,7 +627,7 @@ func (m *Manager) createDefiniteWorkspacePod(startContext *startWorkspaceContext
 			annotations[kubernetes.WorkspaceNetConnLimitAnnotation] = util.BooleanTrueString
 
 		default:
-			return nil, xerrors.Errorf("unknown feature flag: %v", feature)
+			log.Warnf("Unknown feature flag %v", feature)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ import (`
`30`	`30`
`31`	`31`	`"github.com/gitpod-io/gitpod/common-go/kubernetes"`
`32`	`32`	`wsk8s "github.com/gitpod-io/gitpod/common-go/kubernetes"`
	`33`	`+ "github.com/gitpod-io/gitpod/common-go/log"`
`33`	`34`	`"github.com/gitpod-io/gitpod/common-go/tracing"`
`34`	`35`	`"github.com/gitpod-io/gitpod/common-go/util"`
`35`	`36`	`csapi "github.com/gitpod-io/gitpod/content-service/api"`
`@@ -626,7 +627,7 @@ func (m Manager) createDefiniteWorkspacePod(startContext startWorkspaceContext`
`626`	`627`	`annotations[kubernetes.WorkspaceNetConnLimitAnnotation] = util.BooleanTrueString`
`627`	`628`
`628`	`629`	`default:`
`629`		`- return nil, xerrors.Errorf("unknown feature flag: %v", feature)`
	`630`	`+ log.Warnf("Unknown feature flag %v", feature)`
`630`	`631`	`}`
`631`	`632`	`}`
`632`	`633`