Fix bogus query param escaping

Author: AlexTugarev

components/iam/pkg/oidc/service.go

@@ -11,7 +11,6 @@ import (
 	"errors"
 	"io"
 	"net/http"
-	"net/url"
 
 	"github.com/coreos/go-oidc/v3/oidc"
 	"github.com/gitpod-io/gitpod/common-go/log"
@@ -104,15 +103,11 @@ func (service *OIDCService) GetClientConfigFromRequest(r *http.Request) (*OIDCCl
 		return nil, errors.New("issuer param not specified")
 	}
 	log.WithField("issuerParam", issuerParam).Trace("GetClientConfigFromRequest")
-	issuer, err := url.QueryUnescape(issuerParam)
-	if err != nil {
-		return nil, errors.New("bad issuer param")
-	}
-	log.WithField("issuer", issuer).Trace("at GetClientConfigFromRequest")
+	log.WithField("issuer", issuerParam).Trace("at GetClientConfigFromRequest")
 
 	for id, value := range service.configsById {
 		log.WithField("issuer", value.Issuer).WithField("id", id).Trace("GetClientConfigFromRequest (candidate)")
-		if value.Issuer == issuer {
+		if value.Issuer == issuerParam {
 			return value, nil
 		}
 	}

components/iam/pkg/oidc/service_test.go

@@ -10,7 +10,6 @@ import (
 	"log"
 	"net/http"
 	"net/http/httptest"
-	"net/url"
 	"testing"
 
 	"github.com/coreos/go-oidc/v3/oidc"
@@ -72,7 +71,7 @@ func TestGetClientConfigFromRequest(t *testing.T) {
 			ExpectedId:    "",
 		},
 		{
-			Location:      "/start?issuer=" + url.QueryEscape(issuer),
+			Location:      "/start?issuer=" + issuer,
 			ExpectedError: false,
 			ExpectedId:    "google-1",
 		},