Skip to content

Commit 742693f

Browse files
committed
[ws-manager-bridge] When de-registering a workspace cluster, mark any leftover running instances as stopped/failed
1 parent 3d55ab2 commit 742693f

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

components/ws-manager-bridge/src/bridge-controller.ts

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export class BridgeController {
8080
}
8181
} finally {
8282
for (const del of toDelete) {
83+
// TODO(janx): Mark all running instances from cluster `del` as stopped/failed?
8384
this.bridges.delete(del);
8485
}
8586
}

components/ws-manager-bridge/src/cluster-service-server.ts

+2
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,8 @@ export class ClusterService implements IClusterServiceServer {
271271
);
272272
}
273273

274+
// TODO(janx): Mark all `relevantInstances` as stopped/failed?
275+
274276
await this.clusterDB.deleteByName(req.name);
275277
log.info({}, "cluster deregistered", { cluster: req.name });
276278
this.triggerReconcile("deregister", req.name);

0 commit comments

Comments
 (0)