Skip to content

Commit 9144948

Browse files
felladrinAndrea Falzetti
and
Andrea Falzetti
committed
Update Platform Version of JetBrains Backend Plugin to 223.7126-EAP-CANDIDATE-SNAPSHOT
Co-authored-by: Andrea Falzetti <[email protected]>
1 parent 6fde72b commit 9144948

File tree

9 files changed

+55
-6
lines changed

9 files changed

+55
-6
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
22
# for insight into build numbers and IntelliJ Platform versions.
3-
pluginSinceBuild=223
3+
pluginSinceBuild=223.7126
44
pluginUntilBuild=223.*
55
# Plugin Verifier integration -> https://github.com/JetBrains/gradle-intellij-plugin#plugin-verifier-dsl
66
# See https://jb.gg/intellij-platform-builds-list for available build versions.
77
pluginVerifierIdeVersions=2022.3
88
# Version from "com.jetbrains.intellij.idea" which can be found at https://www.jetbrains.com/intellij-repository/snapshots
9-
platformVersion=223.6160-EAP-CANDIDATE-SNAPSHOT
9+
platformVersion=223.7126-EAP-CANDIDATE-SNAPSHOT

Diff for: components/ide/jetbrains/backend-plugin/launch-dev-server.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ TEST_BACKEND_DIR="/workspace/ide-backend-$JB_QUALIFIER"
2828
if [ ! -d "$TEST_BACKEND_DIR" ]; then
2929
mkdir -p $TEST_BACKEND_DIR
3030
if [[ $RUN_FROM == "snapshot" ]]; then
31+
SNAPSHOT_VERSION=$(grep "platformVersion=" "gradle-$JB_QUALIFIER.properties" | sed 's/platformVersion=//')
3132
(cd $TEST_BACKEND_DIR &&
32-
SNAPSHOT_VERSION=$(grep "platformVersion=" "gradle-$JB_QUALIFIER.properties" | sed 's/platformVersion=//') &&
3333
echo "Downloading the $JB_QUALIFIER version of IntelliJ IDEA ($SNAPSHOT_VERSION)..." &&
3434
curl -sSLo backend.zip "https://www.jetbrains.com/intellij-repository/snapshots/com/jetbrains/intellij/idea/ideaIU/$SNAPSHOT_VERSION/ideaIU-$SNAPSHOT_VERSION.zip" &&
3535
unzip backend.zip &&
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License-AGPL.txt in the project root for license information.
4+
5+
package io.gitpod.jetbrains.remote
6+
7+
import java.nio.file.Path
8+
9+
interface GitpodCLIHelper {
10+
suspend fun open(file: Path, shouldWait: Boolean)
11+
}

Diff for: components/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodCLIService.kt

+2-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class GitpodCLIService : RestService() {
4040

4141
private val manager = service<GitpodManager>()
4242
private val portsService = service<GitpodPortsService>()
43+
private val cliHelperService = service<GitpodCLIHelper>()
4344

4445
override fun getServiceName() = SERVICE_NAME
4546

@@ -71,7 +72,7 @@ class GitpodCLIService : RestService() {
7172
return withClient(request, context) {
7273
GlobalScope.launch {
7374
withContext(Dispatchers.IO) {
74-
CommandLineProcessor.doOpenFileOrProject(file, shouldWait).future.get()
75+
cliHelperService.open(file, shouldWait)
7576
}
7677
}
7778
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License-AGPL.txt in the project root for license information.
4+
5+
package io.gitpod.jetbrains.remote.latest
6+
7+
import com.intellij.ide.CommandLineProcessor
8+
import io.gitpod.jetbrains.remote.GitpodCLIHelper
9+
import kotlinx.coroutines.GlobalScope
10+
import kotlinx.coroutines.launch
11+
import java.nio.file.Path
12+
import kotlinx.coroutines.withContext
13+
import kotlinx.coroutines.Dispatchers
14+
15+
@Suppress("UnstableApiUsage", "OPT_IN_USAGE")
16+
class GitpodCLIHelperImpl : GitpodCLIHelper {
17+
override suspend fun open(file :Path, shouldWait: Boolean) {
18+
CommandLineProcessor.doOpenFileOrProject(file, shouldWait).future.await()
19+
}
20+
}

Diff for: components/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/latest/GitpodPortForwardingService.kt

+1-2
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ class GitpodPortForwardingService(private val session: ClientProjectSession) {
104104
hostPort,
105105
PortType.TCP,
106106
setOf(FORWARDED_PORT_LABEL),
107-
hostPort,
108-
ClientPortPickingStrategy.REASSIGN_WHEN_BUSY
107+
ClientPortAttributes(hostPort, ClientPortPickingStrategy.REASSIGN_WHEN_BUSY),
109108
) {
110109
this.name = port.name
111110
this.description = port.description
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
2+
// Licensed under the GNU Affero General Public License (AGPL).
3+
// See License-AGPL.txt in the project root for license information.
4+
5+
package io.gitpod.jetbrains.remote.stable
6+
7+
import com.intellij.ide.CommandLineProcessor
8+
import io.gitpod.jetbrains.remote.GitpodCLIHelper
9+
import java.nio.file.Path
10+
11+
@Suppress("UnstableApiUsage", "OPT_IN_USAGE")
12+
class GitpodCLIHelperImpl : GitpodCLIHelper {
13+
override suspend fun open(file :Path, shouldWait: Boolean) {
14+
CommandLineProcessor.doOpenFileOrProject(file, shouldWait).future.get()
15+
}
16+
}

Diff for: components/ide/jetbrains/backend-plugin/src/main/resources-latest/META-INF/extensions.xml

+1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@
88
<extensions defaultExtensionNs="com.intellij">
99
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodIgnoredPortsForNotificationService" serviceImplementation="io.gitpod.jetbrains.remote.latest.GitpodIgnoredPortsForNotificationServiceImpl" preload="true"/>
1010
<projectService serviceImplementation="io.gitpod.jetbrains.remote.latest.GitpodPortForwardingService" preload="true" client="guest"/>
11+
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodCLIHelper" serviceImplementation="io.gitpod.jetbrains.remote.latest.GitpodCLIHelperImpl" />
1112
</extensions>
1213
</idea-plugin>

Diff for: components/ide/jetbrains/backend-plugin/src/main/resources-stable/META-INF/extensions.xml

+1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@
77
<idea-plugin>
88
<extensions defaultExtensionNs="com.intellij">
99
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodIgnoredPortsForNotificationService" serviceImplementation="io.gitpod.jetbrains.remote.stable.GitpodIgnoredPortsForNotificationServiceImpl" preload="true"/>
10+
<applicationService serviceInterface="io.gitpod.jetbrains.remote.GitpodCLIHelper" serviceImplementation="io.gitpod.jetbrains.remote.stable.GitpodCLIHelperImpl" />
1011
</extensions>
1112
</idea-plugin>

0 commit comments

Comments
 (0)