Skip to content

Commit 9b71206

Browse files
committed
[installer] enable protected_secrets by default
1 parent e564cb4 commit 9b71206

File tree

10 files changed

+55
-31
lines changed

10 files changed

+55
-31
lines changed

Diff for: install/installer/cmd/testdata/render/aws-setup/config.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,6 @@ objectStorage:
2828
credentials:
2929
kind: secret
3030
name: aws-storage
31+
experimental:
32+
workspace:
33+
enableProtectedSecrets: true

Diff for: install/installer/cmd/testdata/render/aws-setup/output.golden

+9-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: install/installer/cmd/testdata/render/azure-setup/config.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,6 @@ objectStorage:
2424
credentials:
2525
kind: secret
2626
name: azure-storage
27+
experimental:
28+
workspace:
29+
enableProtectedSecrets: true

Diff for: install/installer/cmd/testdata/render/azure-setup/output.golden

+9-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: install/installer/cmd/testdata/render/gcp-setup/config.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,6 @@ objectStorage:
2626
serviceAccount:
2727
kind: secret
2828
name: gcp-storage
29+
experimental:
30+
workspace:
31+
enableProtectedSecrets: true

Diff for: install/installer/cmd/testdata/render/gcp-setup/output.golden

+9-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: install/installer/cmd/testdata/render/insecure-s3-setup/config.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,6 @@ objectStorage:
1414
credentials:
1515
kind: secret
1616
name: s3-storage
17+
experimental:
18+
workspace:
19+
enableProtectedSecrets: true

Diff for: install/installer/cmd/testdata/render/insecure-s3-setup/output.golden

+9-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: install/installer/cmd/testdata/render/use-pod-security-policies/output.golden

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: install/installer/pkg/components/server/configmap.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,9 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
165165

166166
defaultFeatureFlags := []NamedWorkspaceFeatureFlag{}
167167
_ = ctx.WithExperimental(func(cfg *experimental.Config) error {
168-
if cfg.Workspace != nil && cfg.Workspace.EnableProtectedSecrets {
168+
if cfg == nil || cfg.Workspace == nil {
169+
defaultFeatureFlags = append(defaultFeatureFlags, NamedWorkspaceFeatureProtectedSecrets)
170+
} else if cfg.Workspace != nil && cfg.Workspace.EnableProtectedSecrets {
169171
defaultFeatureFlags = append(defaultFeatureFlags, NamedWorkspaceFeatureProtectedSecrets)
170172
}
171173
return nil

0 commit comments

Comments
 (0)