[installer]: create build-from-envvars command on config

Author: Simon Emms

install/installer/cmd/config_build-from-envvars.go

@@ -0,0 +1,40 @@
+// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
+// Licensed under the MIT License. See License-MIT.txt in the project root for license information.
+
+package cmd
+
+import (
+	"github.com/gitpod-io/gitpod/installer/pkg/config"
+	"github.com/spf13/cobra"
+)
+
+// configBuildFromEnvvarsCmd represents the validate command
+var configBuildFromEnvvarsCmd = &cobra.Command{
+	Use:   "build-from-envvars",
+	Short: "Build configuration from environment variables",
+	RunE: func(cmd *cobra.Command, args []string) error {
+		if _, err := configFileExistsAndInit(); err != nil {
+			return err
+		}
+
+		_, version, cfg, err := loadConfig(configOpts.ConfigFile)
+		if err != nil {
+			return err
+		}
+
+		apiVersion, err := config.LoadConfigVersion(version)
+		if err != nil {
+			return err
+		}
+
+		if err := apiVersion.BuildFromEnvvars(cfg); err != nil {
+			return err
+		}
+
+		return saveConfigFile(cfg)
+	},
+}
+
+func init() {
+	configCmd.AddCommand(configBuildFromEnvvarsCmd)
+}

install/installer/go.mod

@@ -122,6 +122,7 @@ require (
 	github.com/go-redis/redis/v7 v7.4.1 // indirect
 	github.com/go-redis/redis/v8 v8.11.5 // indirect
 	github.com/go-sql-driver/mysql v1.6.0 // indirect
+	github.com/go-test/deep v1.0.8
 	github.com/gobwas/glob v0.2.3 // indirect
 	github.com/goccy/go-yaml v1.9.5 // indirect
 	github.com/godbus/dbus/v5 v5.0.6 // indirect

install/installer/go.sum

@@ -658,6 +658,8 @@ github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg78
 github.com/go-test/deep v1.0.2-0.20181118220953-042da051cf31/go.mod h1:wGDj63lr65AM2AQyKZd/NYHGb0R+1RLqB8NKt3aSFNA=
 github.com/go-test/deep v1.0.2/go.mod h1:wGDj63lr65AM2AQyKZd/NYHGb0R+1RLqB8NKt3aSFNA=
 github.com/go-test/deep v1.0.7 h1:/VSMRlnY/JSyqxQUzQLKVMAskpY/NZKFA5j2P+0pP2M=
+github.com/go-test/deep v1.0.8 h1:TDsG77qcSprGbC6vTN8OuXp5g+J+b5Pcguhf7Zt61VM=
+github.com/go-test/deep v1.0.8/go.mod h1:5C2ZWiW0ErCdrYzpqxLbTX7MG14M9iiw8DgHncVwcsE=
 github.com/gobuffalo/envy v1.7.0/go.mod h1:n7DRkBerg/aorDM8kbduw5dN3oXGswK5liaSCx4T5NI=
 github.com/gobuffalo/envy v1.7.1/go.mod h1:FurDp9+EDPE4aIUS3ZLyD+7/9fpx7YRt/ukY6jIHf0w=
 github.com/gobuffalo/flect v0.2.2/go.mod h1:vmkQwuZYhN5Pc4ljYQZzP+1sq+NEkK+lh20jmEmX3jc=

install/installer/pkg/config/loader.go

@@ -51,6 +51,9 @@ type ConfigVersion interface {
 	// CheckDeprecated checks for deprecated config params.
 	// Returns key/value pair of deprecated params/values and any error messages (used for conflicting params)
 	CheckDeprecated(cfg interface{}) (map[string]interface{}, []string)
+
+	// BuildFromEnvvars builds the configuration file from assigned envvars
+	BuildFromEnvvars(cfg interface{}) error
 }
 
 // AddVersion adds a new version.

install/installer/pkg/config/v1/config.go

@@ -34,21 +34,28 @@ func (v version) Factory() interface{} {
 		},
 	}
 }
+
+const (
+	defaultRepositoryUrl  = "eu.gcr.io/gitpod-core-dev/build"
+	defaultOpenVSXURL     = "https://open-vsx.org"
+	defaultMetadataRegion = "local"
+)
+
 func (v version) Defaults(in interface{}) error {
 	cfg, ok := in.(*Config)
 	if !ok {
 		return config.ErrInvalidType
 	}
 
 	cfg.Kind = InstallationFull
-	cfg.Repository = "eu.gcr.io/gitpod-core-dev/build"
+	cfg.Repository = defaultRepositoryUrl
 	cfg.Observability = Observability{
 		LogLevel: LogLevelInfo,
 	}
 	cfg.Certificate.Kind = ObjectRefSecret
 	cfg.Certificate.Name = "https-certificates"
 	cfg.Database.InCluster = pointer.Bool(true)
-	cfg.Metadata.Region = "local"
+	cfg.Metadata.Region = defaultMetadataRegion
 	cfg.Metadata.InstallationShortname = InstallationShortNameOldDefault // TODO(gpl): we're tied to "default" here because that's what we put into static bridges in the past
 	cfg.ObjectStorage.InCluster = pointer.Bool(true)
 	cfg.ObjectStorage.Resources = &Resources{
@@ -69,7 +76,7 @@ func (v version) Defaults(in interface{}) error {
 	cfg.Workspace.PVC.Size = resource.MustParse("30Gi")
 	cfg.Workspace.PVC.StorageClass = ""
 	cfg.Workspace.PVC.SnapshotClass = ""
-	cfg.OpenVSX.URL = "https://open-vsx.org"
+	cfg.OpenVSX.URL = defaultOpenVSXURL
 	cfg.DisableDefinitelyGP = true
 
 	return nil