Skip to content

Commit b600fdf

Browse files
committed
call useEffect hook early
Signed-off-by: Tarun Pothulapati <[email protected]>
1 parent 9bc7e58 commit b600fdf

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

components/dashboard/src/admin/Settings.tsx

+7-7
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ export default function Settings() {
2121
const [telemetryData, setTelemetryData] = useState<TelemetryData>();
2222
const { user } = useContext(UserContext);
2323

24+
useEffect(() => {
25+
(async () => {
26+
const data = await getGitpodService().server.adminGetTelemetryData();
27+
setTelemetryData(data)
28+
})();
29+
});
30+
2431
if (!user || !user?.rolesOrPermissions?.includes('admin')) {
2532
return <Redirect to="/"/>
2633
}
@@ -30,13 +37,6 @@ export default function Settings() {
3037
setAdminSettings(value);
3138
}
3239

33-
useEffect(() => {
34-
(async () => {
35-
const data = await getGitpodService().server.adminGetTelemetryData();
36-
setTelemetryData(data)
37-
})();
38-
});
39-
4040
return (
4141
<div>
4242
<PageWithSubMenu subMenu={adminMenu} title="Settings" subtitle="Configure settings for your Gitpod cluster.">

0 commit comments

Comments
 (0)