Skip to content

Commit bc47002

Browse files
filiptronicekakosyakov
filiptronicek
and
akosyakov
committed
[code browser]: Measure all sessions vs errored sessions
Co-authored-by: Anton Kosyakov <[email protected]>
1 parent 4b4e1d5 commit bc47002

File tree

11 files changed

+147
-10
lines changed

11 files changed

+147
-10
lines changed

‎components/supervisor/frontend/src/ide/ide-metrics-service-client.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import { serverUrl } from '../shared/urls';
88

99
export enum MetricsName {
1010
SupervisorFrontendClientTotal = "gitpod_supervisor_frontend_client_total",
11-
SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total"
11+
SupervisorFrontendErrorTotal = "gitpod_supervisor_frontend_error_total",
12+
SupervisorFrontendLoadTotal = "gitpod_vscode_web_load_total",
1213
}
1314

1415
const MetricsUrl = serverUrl.asIDEMetrics().toString();

‎install/installer/cmd/testdata/render/aws-setup/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3165,6 +3165,20 @@ data:
31653165
}
31663166
]
31673167
},
3168+
{
3169+
"name": "gitpod_vscode_web_load_total",
3170+
"help": "Total count of supervisor frontend client loading / errored windows",
3171+
"labels": [
3172+
{
3173+
"name": "status",
3174+
"allowValues": [
3175+
"loading",
3176+
"failed"
3177+
],
3178+
"defaultValue": ""
3179+
}
3180+
]
3181+
},
31683182
{
31693183
"name": "gitpod_supervisor_frontend_client_total",
31703184
"help": "Total count of supervisor frontend client",
@@ -7431,7 +7445,7 @@ spec:
74317445
template:
74327446
metadata:
74337447
annotations:
7434-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
7448+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
74357449
creationTimestamp: null
74367450
labels:
74377451
app: gitpod

‎install/installer/cmd/testdata/render/azure-setup/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3083,6 +3083,20 @@ data:
30833083
}
30843084
]
30853085
},
3086+
{
3087+
"name": "gitpod_vscode_web_load_total",
3088+
"help": "Total count of supervisor frontend client loading / errored windows",
3089+
"labels": [
3090+
{
3091+
"name": "status",
3092+
"allowValues": [
3093+
"loading",
3094+
"failed"
3095+
],
3096+
"defaultValue": ""
3097+
}
3098+
]
3099+
},
30863100
{
30873101
"name": "gitpod_supervisor_frontend_client_total",
30883102
"help": "Total count of supervisor frontend client",
@@ -7265,7 +7279,7 @@ spec:
72657279
template:
72667280
metadata:
72677281
annotations:
7268-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
7282+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
72697283
creationTimestamp: null
72707284
labels:
72717285
app: gitpod

‎install/installer/cmd/testdata/render/customization/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3865,6 +3865,20 @@ data:
38653865
}
38663866
]
38673867
},
3868+
{
3869+
"name": "gitpod_vscode_web_load_total",
3870+
"help": "Total count of supervisor frontend client loading / errored windows",
3871+
"labels": [
3872+
{
3873+
"name": "status",
3874+
"allowValues": [
3875+
"loading",
3876+
"failed"
3877+
],
3878+
"defaultValue": ""
3879+
}
3880+
]
3881+
},
38683882
{
38693883
"name": "gitpod_supervisor_frontend_client_total",
38703884
"help": "Total count of supervisor frontend client",
@@ -8658,7 +8672,7 @@ spec:
86588672
metadata:
86598673
annotations:
86608674
gitpod.io: hello
8661-
gitpod.io/checksum_config: 8beda82ff6c689641e3e3d74cfa333942daf49ba5617133a5c6ec21a44408f22
8675+
gitpod.io/checksum_config: 8aa9b1bcf89417e5ff2353d33891b50ff53411c4255430c3ed4329d7c707739f
86628676
hello: world
86638677
creationTimestamp: null
86648678
labels:

‎install/installer/cmd/testdata/render/external-registry/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3224,6 +3224,20 @@ data:
32243224
}
32253225
]
32263226
},
3227+
{
3228+
"name": "gitpod_vscode_web_load_total",
3229+
"help": "Total count of supervisor frontend client loading / errored windows",
3230+
"labels": [
3231+
{
3232+
"name": "status",
3233+
"allowValues": [
3234+
"loading",
3235+
"failed"
3236+
],
3237+
"defaultValue": ""
3238+
}
3239+
]
3240+
},
32273241
{
32283242
"name": "gitpod_supervisor_frontend_client_total",
32293243
"help": "Total count of supervisor frontend client",
@@ -7706,7 +7720,7 @@ spec:
77067720
template:
77077721
metadata:
77087722
annotations:
7709-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
7723+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
77107724
creationTimestamp: null
77117725
labels:
77127726
app: gitpod

‎install/installer/cmd/testdata/render/gcp-setup/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3054,6 +3054,20 @@ data:
30543054
}
30553055
]
30563056
},
3057+
{
3058+
"name": "gitpod_vscode_web_load_total",
3059+
"help": "Total count of supervisor frontend client loading / errored windows",
3060+
"labels": [
3061+
{
3062+
"name": "status",
3063+
"allowValues": [
3064+
"loading",
3065+
"failed"
3066+
],
3067+
"defaultValue": ""
3068+
}
3069+
]
3070+
},
30573071
{
30583072
"name": "gitpod_supervisor_frontend_client_total",
30593073
"help": "Total count of supervisor frontend client",
@@ -7320,7 +7334,7 @@ spec:
73207334
template:
73217335
metadata:
73227336
annotations:
7323-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
7337+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
73247338
creationTimestamp: null
73257339
labels:
73267340
app: gitpod

‎install/installer/cmd/testdata/render/minimal/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3390,6 +3390,20 @@ data:
33903390
}
33913391
]
33923392
},
3393+
{
3394+
"name": "gitpod_vscode_web_load_total",
3395+
"help": "Total count of supervisor frontend client loading / errored windows",
3396+
"labels": [
3397+
{
3398+
"name": "status",
3399+
"allowValues": [
3400+
"loading",
3401+
"failed"
3402+
],
3403+
"defaultValue": ""
3404+
}
3405+
]
3406+
},
33933407
{
33943408
"name": "gitpod_supervisor_frontend_client_total",
33953409
"help": "Total count of supervisor frontend client",
@@ -7986,7 +8000,7 @@ spec:
79868000
template:
79878001
metadata:
79888002
annotations:
7989-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
8003+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
79908004
creationTimestamp: null
79918005
labels:
79928006
app: gitpod

‎install/installer/cmd/testdata/render/statefulset-customization/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3402,6 +3402,20 @@ data:
34023402
}
34033403
]
34043404
},
3405+
{
3406+
"name": "gitpod_vscode_web_load_total",
3407+
"help": "Total count of supervisor frontend client loading / errored windows",
3408+
"labels": [
3409+
{
3410+
"name": "status",
3411+
"allowValues": [
3412+
"loading",
3413+
"failed"
3414+
],
3415+
"defaultValue": ""
3416+
}
3417+
]
3418+
},
34053419
{
34063420
"name": "gitpod_supervisor_frontend_client_total",
34073421
"help": "Total count of supervisor frontend client",
@@ -7998,7 +8012,7 @@ spec:
79988012
template:
79998013
metadata:
80008014
annotations:
8001-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
8015+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
80028016
creationTimestamp: null
80038017
labels:
80048018
app: gitpod

‎install/installer/cmd/testdata/render/use-pod-security-policies/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3723,6 +3723,20 @@ data:
37233723
}
37243724
]
37253725
},
3726+
{
3727+
"name": "gitpod_vscode_web_load_total",
3728+
"help": "Total count of supervisor frontend client loading / errored windows",
3729+
"labels": [
3730+
{
3731+
"name": "status",
3732+
"allowValues": [
3733+
"loading",
3734+
"failed"
3735+
],
3736+
"defaultValue": ""
3737+
}
3738+
]
3739+
},
37263740
{
37273741
"name": "gitpod_supervisor_frontend_client_total",
37283742
"help": "Total count of supervisor frontend client",
@@ -8430,7 +8444,7 @@ spec:
84308444
template:
84318445
metadata:
84328446
annotations:
8433-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
8447+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
84348448
creationTimestamp: null
84358449
labels:
84368450
app: gitpod

‎install/installer/cmd/testdata/render/workspace-requests-limits/output.golden

+15-1
Original file line numberDiff line numberDiff line change
@@ -3393,6 +3393,20 @@ data:
33933393
}
33943394
]
33953395
},
3396+
{
3397+
"name": "gitpod_vscode_web_load_total",
3398+
"help": "Total count of supervisor frontend client loading / errored windows",
3399+
"labels": [
3400+
{
3401+
"name": "status",
3402+
"allowValues": [
3403+
"loading",
3404+
"failed"
3405+
],
3406+
"defaultValue": ""
3407+
}
3408+
]
3409+
},
33963410
{
33973411
"name": "gitpod_supervisor_frontend_client_total",
33983412
"help": "Total count of supervisor frontend client",
@@ -7989,7 +8003,7 @@ spec:
79898003
template:
79908004
metadata:
79918005
annotations:
7992-
gitpod.io/checksum_config: 5f647d019f026f04a85e04ad8e695083db2a70f97ee7199143859879d5d40ebe
8006+
gitpod.io/checksum_config: 99857889bb5dd2fe08efbb38fa510956566ce067cf2d1e1e945bd024cf4c6bb3
79938007
creationTimestamp: null
79948008
labels:
79958009
app: gitpod

‎install/installer/pkg/components/ide-metrics/configmap.go

+10
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,16 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
4646
},
4747
},
4848
},
49+
{
50+
Name: "gitpod_vscode_web_load_total",
51+
Help: "Total count of supervisor frontend client loading / errored windows",
52+
Labels: []config.LabelAllowList{
53+
{
54+
Name: "status",
55+
AllowValues: []string{"loading", "failed"},
56+
},
57+
},
58+
},
4959
{
5060
Name: "gitpod_supervisor_frontend_client_total",
5161
Help: "Total count of supervisor frontend client",

0 commit comments

Comments
 (0)