Unset GOFLAGS from Dockerfile

vulkoingim · roboquat · commit d2e2badace64 · 2022-09-16T08:56:17.000+02:00
diff --git a/.gitpod.yml b/.gitpod.yml
@@ -1,4 +1,4 @@
-image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
 workspaceLocation: gitpod/gitpod-ws.code-workspace
 checkoutLocation: gitpod
 ports:
diff --git a/.werft/aks-installer-tests.yaml b/.werft/aks-installer-tests.yaml
@@ -53,7 +53,7 @@ pod:
       secretName: sh-playground-dns-perm
   containers:
   - name: nightly-test
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: Always
     volumeMounts:
diff --git a/.werft/build.yaml b/.werft/build.yaml
@@ -75,7 +75,7 @@ pod:
     - name: MYSQL_TCP_PORT
       value: 23306
   - name: build
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: IfNotPresent
     resources:
diff --git a/.werft/cleanup-installer-tests.yaml b/.werft/cleanup-installer-tests.yaml
@@ -24,7 +24,7 @@ pod:
       secretName: aks-credentials
   containers:
   - name: nightly-test
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: Always
     volumeMounts:
diff --git a/.werft/debug.yaml b/.werft/debug.yaml
@@ -53,7 +53,7 @@ pod:
     - name: MYSQL_TCP_PORT
       value: 23306
   - name: build
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: IfNotPresent
     volumeMounts:
diff --git a/.werft/eks-installer-tests.yaml b/.werft/eks-installer-tests.yaml
@@ -53,7 +53,7 @@ pod:
       secretName: sh-playground-dns-perm
   containers:
   - name: nightly-test
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: Always
     volumeMounts:
diff --git a/.werft/gke-installer-tests.yaml b/.werft/gke-installer-tests.yaml
@@ -53,7 +53,7 @@ pod:
         secretName: sh-playground-dns-perm
   containers:
     - name: nightly-test
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: Always
       volumeMounts:
diff --git a/.werft/ide-integration-tests-startup.yaml b/.werft/ide-integration-tests-startup.yaml
@@ -16,7 +16,7 @@ pod:
         secretName: github-token-gitpod-bot
   containers:
     - name: gcloud
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: IfNotPresent
       env:
diff --git a/.werft/k3s-installer-tests.yaml b/.werft/k3s-installer-tests.yaml
@@ -53,7 +53,7 @@ pod:
       secretName: sh-playground-dns-perm
   containers:
   - name: nightly-test
-    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+    image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
     workingDir: /workspace
     imagePullPolicy: Always
     volumeMounts:
diff --git a/.werft/platform-delete-preview-environments-cron.yaml b/.werft/platform-delete-preview-environments-cron.yaml
@@ -28,7 +28,7 @@ pod:
         secretName: github-token-gitpod-bot
   containers:
     - name: build
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: IfNotPresent
       volumeMounts:
diff --git a/.werft/platform-trigger-werft-cleanup.yaml b/.werft/platform-trigger-werft-cleanup.yaml
@@ -21,7 +21,7 @@ pod:
         secretName: gcp-sa-gitpod-dev-deployer
   containers:
     - name: build
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: IfNotPresent
       volumeMounts:
diff --git a/.werft/run-integration-tests.yaml b/.werft/run-integration-tests.yaml
@@ -22,7 +22,7 @@ pod:
       emptyDir: {}
   initContainers:
     - name: gcloud
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: IfNotPresent
       volumeMounts:
diff --git a/.werft/workspace-run-integration-tests.yaml b/.werft/workspace-run-integration-tests.yaml
@@ -21,7 +21,7 @@ pod:
         secretName: github-token-gitpod-bot
   containers:
     - name: gcloud
-      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0
+      image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0
       workingDir: /workspace
       imagePullPolicy: IfNotPresent
       env:
diff --git a/dev/image/Dockerfile b/dev/image/Dockerfile
@@ -137,9 +137,6 @@ RUN bash -c ". .nvm/nvm.sh \
     && npm install -g typescript yarn"
 ENV PATH=/home/gitpod/.nvm/versions/node/v${GITPOD_NODE_VERSION}/bin:$PATH
 
-# Go
-ENV GOFLAGS="-mod=readonly"
-
 ## Register leeway autocompletion in bashrc
 RUN bash -c "echo . \<\(leeway bash-completion\) >> ~/.bashrc"
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:pd-dev-upgrade.0`
	`1`	`+image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aa-unset-goflags.0`
`2`	`2`	`workspaceLocation: gitpod/gitpod-ws.code-workspace`
`3`	`3`	`checkoutLocation: gitpod`
`4`	`4`	`ports:`