[installer] enable protected_secrets by default

Signed-off-by: JenTing Hsiao <[email protected]>

Author: kylos101

install/installer/cmd/testdata/render/aws-setup/output.golden

@@ -163,10 +163,15 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
 		return nil
 	})
 
-	defaultFeatureFlags := []NamedWorkspaceFeatureFlag{}
+	// Enable protected_secrets by default
+	defaultFeatureFlags := []NamedWorkspaceFeatureFlag{NamedWorkspaceFeatureProtectedSecrets}
 	_ = ctx.WithExperimental(func(cfg *experimental.Config) error {
-		if cfg.Workspace != nil && cfg.Workspace.EnableProtectedSecrets {
-			defaultFeatureFlags = append(defaultFeatureFlags, NamedWorkspaceFeatureProtectedSecrets)
+		if cfg == nil || cfg.Workspace == nil || cfg.Workspace.EnableProtectedSecrets == nil {
+			return nil
+		}
+		if !*cfg.Workspace.EnableProtectedSecrets {
+			// Disable protected_secrets if it explicitly set to false in the installer configuration
+			defaultFeatureFlags = []NamedWorkspaceFeatureFlag{}
 		}
 		return nil
 	})

install/installer/cmd/testdata/render/azure-setup/output.golden

@@ -120,7 +120,7 @@ type WorkspaceConfig struct {
 		UsageReportBucketName string `json:"usageReportBucketName"`
 	} `json:"contentService"`
 
-	EnableProtectedSecrets bool `json:"enableProtectedSecrets"`
+	EnableProtectedSecrets *bool `json:"enableProtectedSecrets"`
 }
 
 type PersistentVolumeClaim struct {