Skip to content

Commit dfacdcb

Browse files
committed
Variable shadowing
Signed-off-by: JenTing Hsiao <[email protected]>
1 parent 0f08df1 commit dfacdcb

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

test/tests/components/ws-manager/content_test.go

+5-10
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ func TestBackup(t *testing.T) {
6868
integration.WithWorkspacekitLift(true),
6969
)
7070
if err != nil {
71-
_, err := stopWs1(true)
72-
if err != nil {
71+
if _, err := stopWs1(true); err != nil {
7372
t.Errorf("cannot stop workspace: %q", err)
7473
}
7574
t.Fatal(err)
@@ -84,8 +83,7 @@ func TestBackup(t *testing.T) {
8483
}, &resp)
8584
rsa.Close()
8685
if err != nil {
87-
_, err = stopWs1(true)
88-
if err != nil {
86+
if _, err := stopWs1(true); err != nil {
8987
t.Errorf("cannot stop workspace: %q", err)
9088
}
9189
t.Fatal(err)
@@ -202,8 +200,7 @@ func TestExistingWorkspaceEnablePVC(t *testing.T) {
202200
integration.WithWorkspacekitLift(true),
203201
)
204202
if err != nil {
205-
_, err := stopWs1(true)
206-
if err != nil {
203+
if _, err := stopWs1(true); err != nil {
207204
t.Errorf("cannot stop workspace: %q", err)
208205
}
209206
t.Fatal(err)
@@ -218,8 +215,7 @@ func TestExistingWorkspaceEnablePVC(t *testing.T) {
218215
}, &resp)
219216
rsa.Close()
220217
if err != nil {
221-
_, err = stopWs1(true)
222-
if err != nil {
218+
if _, err := stopWs1(true); err != nil {
223219
t.Errorf("cannot stop workspace: %q", err)
224220
}
225221
t.Fatal(err)
@@ -307,8 +303,7 @@ func TestMissingBackup(t *testing.T) {
307303

308304
wsm, err := api.WorkspaceManager()
309305
if err != nil {
310-
_, err = stopWs(true)
311-
if err != nil {
306+
if _, err := stopWs(true); err != nil {
312307
t.Errorf("cannot stop workspace: %q", err)
313308
}
314309
t.Fatal(err)

0 commit comments

Comments
 (0)