Skip to content

Commit edfd76d

Browse files
aledbfroboquat
authored andcommitted
Log JSON as strings not an array of bytes
1 parent 0a0ceb9 commit edfd76d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Diff for: components/image-builder-mk3/pkg/orchestrator/orchestrator.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ func (o *Orchestrator) ResolveBaseImage(ctx context.Context, req *protocol.Resol
151151

152152
reqs, _ := protojson.Marshal(req)
153153
safeReqs, _ := log.RedactJSON(reqs)
154-
log.WithField("req", safeReqs).Debug("ResolveBaseImage")
154+
log.WithField("req", string(safeReqs)).Debug("ResolveBaseImage")
155155

156156
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
157157

@@ -173,7 +173,7 @@ func (o *Orchestrator) ResolveWorkspaceImage(ctx context.Context, req *protocol.
173173

174174
reqs, _ := protojson.Marshal(req)
175175
safeReqs, _ := log.RedactJSON(reqs)
176-
log.WithField("req", safeReqs).Debug("ResolveWorkspaceImage")
176+
log.WithField("req", string(safeReqs)).Debug("ResolveWorkspaceImage")
177177

178178
reqauth := o.AuthResolver.ResolveRequestAuth(req.Auth)
179179
baseref, err := o.getBaseImageRef(ctx, req.Source, reqauth)

Diff for: components/ws-manager/pkg/manager/manager.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1360,12 +1360,12 @@ func (m *Manager) onChange(ctx context.Context, status *api.WorkspaceStatus) {
13601360
if status.Conditions.Failed != "" {
13611361
status, _ := protojson.Marshal(status)
13621362
safeStatus, _ := log.RedactJSON(status)
1363-
clog.WithField("status", safeStatus).Error("workspace failed")
1363+
clog.WithField("status", string(safeStatus)).Error("workspace failed")
13641364
}
13651365
if status.Phase == 0 {
13661366
status, _ := protojson.Marshal(status)
13671367
safeStatus, _ := log.RedactJSON(status)
1368-
clog.WithField("status", safeStatus).Error("workspace in UNKNOWN phase")
1368+
clog.WithField("status", string(safeStatus)).Error("workspace in UNKNOWN phase")
13691369
}
13701370
}
13711371

0 commit comments

Comments
 (0)