[installer] Support PVC size config for docker-registry

[nandajavarma]

Is your feature request related to a problem? Please describe

Currently, we do not support the configuration of PVC storage size for docker-registry component in the helm config. We seem to be setting the default value 10Gi in the generated config. Considering workspace images can be large in size, it might be useful if we can support configuration of this value(docker-registry.persistence.size) from the installer config.

Describe the behaviour you'd like

We should be able to set the size request of the PVC if the user has chosen incluster container registry option.

Describe alternatives you've considered

Alternatively we could suggest a periodic cleanup job of old images as suggested by a user on discord.

Additional context

[mrsimonemms]

EDIT: it's before 8am, I've not had my tea and I misread docker-registry with mysql. Have updated comment

I had a look at this a few weeks ago as part of #9698 and it actually looks quite difficult to change a PVC now and support everything that's currently out there.

The in-cluster dependencies are not designed to be a one-size fits all solution for every use case. In reality, they're a limited solution to get people up and running quickly. There are so many configuration options out there that we could never expect to capture every nuance without placing a massive support burden on our team.

What we decided as part of the original issue was to document how to deploy their own DB/Registry/Storage to their cluster to their own requirements - see #11178.

What I would suggest is for the OP to check out the Twuni Registry Helm chart and configure their own registry instance and use that instead of the Gitpod in-cluster configuration. From the KOTS config, this will be an external registry and the URL will be something like registry.namespace.svc.cluster.local