Skip to content

[code-desktop] Align on a way to ensure Gitpod API compatibility between IDE clients and SH installations. #12254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akosyakov opened this issue Aug 22, 2022 · 2 comments
Closed

[code-desktop] Align on a way to ensure Gitpod API compatibility between IDE clients and SH installations. #12254

akosyakov opened this issue Aug 22, 2022 · 2 comments
Assignees
@jeanp413
Labels
component: server editor: code (desktop) self-hosted team: IDE

Comments

@akosyakov
Copy link
Member

  • We decided to change how ouath2 endpoint works. It should ignore unknown scopes, verify and return only subset of known scopes. Clients should use returned scopes as source of truth to check whether features are present. It is for instance how GitHub auth works.
  • We will still need to adhere to api/version for 2 SH releases which has changes to ouath2 endpoint. After this check can be removed.

Internal RFC [1]
@akosyakov akosyakov moved this to Scheduled in 🚀 IDE Team Aug 22, 2022
@jeanp413 jeanp413 mentioned this issue Aug 24, 2022
Closed
2 tasks
@akosyakov akosyakov moved this from Scheduled to In Progress in 🚀 IDE Team Aug 25, 2022
This was referenced Aug 26, 2022
Merged
Merged
@loujaybee
Copy link
Member

loujaybee commented Sep 5, 2022 •
edited
Loading

Current update: The PR Is up...

But we need to resolve some of the outstanding discussions, would be good to get @geropl and WebApp teams help to unblock this one 🙏

@jeanp413
Copy link
Member

jeanp413 commented Sep 6, 2022

Closing this as it got deployed

@jeanp413 jeanp413 closed this as completed Sep 6, 2022
Repository owner moved this from In Progress to Done in 🚀 IDE Team Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanp413 jeanp413

Labels
component: server editor: code (desktop) self-hosted team: IDE
Projects
🚀 IDE Team
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @loujaybee @jeanp413