Skip to content

Adjust cost centers and usage limits depending to spec #13389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #13301
jankeromnes opened this issue Sep 28, 2022 · 3 comments
Closed
Tracked by #13301

Adjust cost centers and usage limits depending to spec #13389

jankeromnes opened this issue Sep 28, 2022 · 3 comments
Assignees
Labels
team: webapp Issue belongs to the WebApp team

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 28, 2022

For un-upgraded cost centers (i.e. not Stripe customer), the usage limit should be:

  • 500 credits for individiual users (the free tier)
  • 0 credits for teams

These should also not be customizable (hard usage limit).

Then, for upgraded cost centers (i.e. Stripe customers), the usage limits should default to:

  • 1000 credits for individual users (customizable, but you can only set it to >= 1000 credits)
  • 1000 credits * team members for teams (customizable to any value)
@jankeromnes jankeromnes added the team: webapp Issue belongs to the WebApp team label Sep 28, 2022
@jankeromnes jankeromnes moved this to In Progress in 🍎 WebApp Team Sep 28, 2022
@jankeromnes jankeromnes self-assigned this Sep 28, 2022
@jankeromnes jankeromnes changed the title Make sure all individuals get a default cost center with the correct free monthly usage limit Make sure usage-based individual customers get a default cost center with the correct free monthly usage limit Sep 28, 2022
@jankeromnes jankeromnes removed their assignment Oct 4, 2022
@jankeromnes jankeromnes moved this from In Progress to Scheduled in 🍎 WebApp Team Oct 4, 2022
@jankeromnes jankeromnes changed the title Make sure usage-based individual customers get a default cost center with the correct free monthly usage limit Adjust cost centers and usage limits depending to spec Oct 10, 2022
@jankeromnes
Copy link
Contributor Author

In addition to the customizable / non-customizable / minimum value specs mentioned above, there is a suggestion by @svenefftinge to always ask new Stripe customers what limit they want when they sign up:

Would it be better to ask the user what spending limit they want when they create a team? Hardcoding this in the backend doesn't seem to make so much sense, as e.g. the spending limit for teams greatly varies with the team size.
I've put the defaults into the usage component because of the get-or-create semantic of cost centers. But they will always be created as billingStrategy: other and Stripe cost centers are always created by users, so we can also pass the spendingLimit. Happy to discuss

I guess this requires further alignment on what we do by default; what we ask for and when; and how we enforce the minimum / non-customizable values.

@easyCZ
Copy link
Member

easyCZ commented Oct 10, 2022

While doing this, it would be great to do it in a such a way that it complements the other scheduled issue in the current sprint - #13198 - that is move more of the handling logic to usage.

@jankeromnes
Copy link
Contributor Author

Fixed in #13746 and #13798

Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Oct 13, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: webapp Issue belongs to the WebApp team
Projects
Status: Done
2 participants