Skip to content

Don't add previewctl to our dev image #14149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mads-hartmann opened this issue Oct 25, 2022 · 1 comment · Fixed by #14795
Closed

Don't add previewctl to our dev image #14149

mads-hartmann opened this issue Oct 25, 2022 · 1 comment · Fixed by #14795
Assignees

Comments

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Oct 25, 2022

Currently we add previewctl to our dev image (source).

This means that whenever we update previewctl we'll have to build a new Docker image and update all jobs. This is tedious and slow. See example PR here.

We should see if we can remove previewctl from the image and instead use the binary built by Leeway in the different environments

  1. For Gitpod Workspaces we can build previewctl as part of our prebuild configuration. We have to ensure it's on the PATH. We'd also have to install bash completions there and remove it from the Dockerfile (source)
  2. For the Werft build job we should be able to use the previewctl that we create as part of the build

If we use previewctl in other Werft jobs we'll have to figure out solutions there too.

Note: This is also true for kubecdl and gpctl - if it makes sense we could do the same for them.

@meysholdt
Copy link
Member

Proposed solution: Leeway should build this, and all scripts that need it should have it as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants