Skip to content

[Dashboard] Environment Variables Page #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Mar 9, 2021 · 0 comments · Fixed by #3581
Closed

[Dashboard] Environment Variables Page #3400

gtsiolis opened this issue Mar 9, 2021 · 0 comments · Fixed by #3581

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 9, 2021

Problem to solve

Currently, Environment Variables are mixed with other user settings like API Tokens, Notifications, etc.

This is part of #3300. 🍕

User Experience goal

The user should be able to create, read, update, and delete (CRUD) environments variables for their account but also specify a target project for each environment variable.

Proposal

In this first MVC (minimum viable change), we can do the following:

  1. Introduce a dedicated page for creating, reading, updating, and deleting environment variables.
  2. (Optional) Rename Environment Variables to Variables to make it friendlier to the user but also allow future features like supporting other types (see Support multiline environment variables #2058), etc.
  3. Show a modal dialog to prompt the user for a variable key, value, and project scope.
  4. Hide the variable value by default on the variables list. See Initially hide environment variable values in Settings page #1534.
  5. Allow the user to read, edit, and delete a variable from the list in a modal.
  6. Make the variable visible only within the modal.

Components involved:

  1. Text Field
  2. Button
  3. Modal
  4. Table or List

Future steps

  1. In the future, we could introduce a button to toggle visibility of the variable value.
  2. Suport multiline variables.

Designs

List Empty Create Edit
image image image image

For spacing guidelines, see similar patterns in #3399.

See also design specs.

Documentation

No documentation changes are needed for this first iteration.

@gtsiolis gtsiolis changed the title [Dashboard] Environment Variables Page #3398 [Dashboard] Environment Variables Page Mar 9, 2021
@gtsiolis gtsiolis added this to the March 2021 milestone Mar 9, 2021
@svenefftinge svenefftinge self-assigned this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants