Skip to content

Container Registry and S3 Clarification In The Docs #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eiymba opened this issue Feb 18, 2022 · 0 comments · Fixed by #8322
Closed

Container Registry and S3 Clarification In The Docs #8321

eiymba opened this issue Feb 18, 2022 · 0 comments · Fixed by #8322
Assignees
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team

Comments

@eiymba
Copy link

eiymba commented Feb 18, 2022

The EKS installer's bash script modifies this parameter such that it it reads:

containerRegistry:
  ...
  s3storage:
    bucket: <bucket>
  ...

However, the actual readme of the installer suggests this yaml format:

containerRegistry:
  inCluster: false
  external:
    url: <url of registry>
    certificate:
      kind: secret
      name: container-registry-token

So, am I correct it thinking that we can either use S3 as a container registry, or use an external private container registry?

@mrsimonemms mrsimonemms self-assigned this Feb 18, 2022
@mrsimonemms mrsimonemms added component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants