Skip to content

Remove dead code: Probe Workspaces #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corneliusludmann opened this issue Mar 1, 2022 · 2 comments
Closed

Remove dead code: Probe Workspaces #8505

corneliusludmann opened this issue Mar 1, 2022 · 2 comments
Assignees
Labels
component: server team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@corneliusludmann
Copy link
Contributor

In the past, we used probe workspaces to check if a workspace cluster is working:

// startWorkspaceProbe creates and starts a new workspace which is independent of external services and curls a response URL as init task
async startWorkspaceProbe(ctx: TraceContext, responseURL: string, responseToken: string): Promise<void> {

However, we do not support and use probe workspaces anymore. We should remove all the dead code around probe workspace. That includes:

  • The function mentioned above.
  • The workspace templates for probe workspaces.
  • Maybe other references of probe workspaces in the repo.

More context: https://gitpod.slack.com/archives/C02F19UUW6S/p1646075269171699 (internal)

@corneliusludmann corneliusludmann added component: server type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Mar 1, 2022
@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 30, 2022
@stale stale bot closed this as completed Jun 29, 2022
@AlexTugarev AlexTugarev reopened this Sep 26, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Sep 26, 2022
@easyCZ easyCZ moved this to In Progress in 🍎 WebApp Team Sep 27, 2022
@easyCZ easyCZ self-assigned this Sep 27, 2022
@easyCZ easyCZ moved this from In Progress to In Validation in 🍎 WebApp Team Sep 27, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Sep 29, 2022
@geropl
Copy link
Member

geropl commented Oct 7, 2022

Closing because it's marked as "done".

@geropl geropl closed this as completed Oct 7, 2022
Repository owner moved this from Done to In Validation in 🍎 WebApp Team Oct 7, 2022
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

No branches or pull requests

4 participants