Skip to content

Disable empty string search on admin workspace search #8614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
laushinka opened this issue Mar 4, 2022 · 0 comments · Fixed by #8632
Closed

Disable empty string search on admin workspace search #8614

laushinka opened this issue Mar 4, 2022 · 0 comments · Fixed by #8632

Comments

@laushinka
Copy link
Contributor

Currently, all the admin dashboard searches allow an empty string search, which would return all the rows.
Unfortunately, an empty string search on the admin workspace will spike our DB load and CPU usage, therefore can cause incidents[1].

We should disable it.
@laushinka laushinka moved this to Scheduled in 🍎 WebApp Team Mar 4, 2022
@laushinka laushinka mentioned this issue Mar 7, 2022
Merged
Repository owner moved this from Scheduled to Done in 🍎 WebApp Team Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🍎 WebApp Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow exact-matching of workspace search gitpod-io/gitpod
1 participant
@laushinka