Skip to content

.werft/publish-kots: Move method under buildAndPublish #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArthurSens opened this issue Apr 1, 2022 · 1 comment · Fixed by #9202
Closed

.werft/publish-kots: Move method under buildAndPublish #9080

ArthurSens opened this issue Apr 1, 2022 · 1 comment · Fixed by #9202

Comments

@ArthurSens
Copy link
Contributor

👋 coming for a late review 😅

Does it make sense to move publish-to-kots to be a method under buildAndPublish?

I'm thinking of keeping built.ts as small as possible, while putting logic where it makes sense 🙂 (I can create an issue for that if that's agreed

cc @gitpod-io/platform

Originally posted by @ArthurSens in #9070 (comment)
@mads-hartmann
Copy link
Contributor

Moving to the "Reducing Technical Debt" epic.

@ArthurSens ArthurSens mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
☁️ DevX by 🚚 Delivery and Operations Experience Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move publish Kots method under buildAndPublish gitpod-io/gitpod
2 participants
@mads-hartmann @ArthurSens