Skip to content

Clean up Node Affinity Labels for Self Hosted to not use meta #9562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #9072
lucasvaltl opened this issue Apr 26, 2022 · 1 comment
Closed
Tracked by #9072

Clean up Node Affinity Labels for Self Hosted to not use meta #9562

lucasvaltl opened this issue Apr 26, 2022 · 1 comment

Comments

@lucasvaltl
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, we require the following node affinity labels for a cluster that runs Gitpod Self-Hosted:

  • gitpod.io/workload_meta=true
  • gitpod.io/workload_ide=true
  • gitpod.io/workload_workspace_services=true
  • gitpod.io/workload_workspace_regular=true
  • gitpod.io/workload_workspace_headless=true
    --> we are still using the word meta here

Describe the behaviour you'd like

  • Given that meta is a thing of the past, we should rename this label into server, or better group ide and meta into services.

Additional context

Internal discussion here.

@lucasvaltl
Copy link
Contributor Author

Breaking change to every Gitpod installation out there - likely not worth the effort. Benefit - removes naming inconsistency. Drawback - everyone has to update Gitpod and their nodelabels. Won't do for now.

Repository owner moved this from 🧊Backlog to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant