Skip to content

Commit e695b0d

Browse files
committed
Remove CommitList::marked() to avoid exposing internal structure
1 parent 8b71734 commit e695b0d

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

src/components/commitlist.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,6 @@ impl CommitList {
117117
self.marked.len()
118118
}
119119

120-
///
121-
#[expect(
122-
clippy::missing_const_for_fn,
123-
reason = "as of 1.86.0 clippy wants this to be const even though that breaks"
124-
)]
125-
pub fn marked(&self) -> &[(usize, CommitId)] {
126-
&self.marked
127-
}
128-
129120
///
130121
pub fn clear_marked(&mut self) {
131122
self.marked.clear();

src/tabs/revlog.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -586,19 +586,19 @@ impl Component for Revlog {
586586
self.queue.push(InternalEvent::OpenPopup(
587587
StackablePopupOpen::CompareCommits(
588588
InspectCommitOpen::new(
589-
self.list.marked()[0].1,
589+
self.list.marked_commits()[0],
590590
),
591591
),
592592
));
593593
return Ok(EventState::Consumed);
594594
} else if self.list.marked_count() == 2 {
595595
//compare two marked commits
596-
let marked = self.list.marked();
596+
let marked = self.list.marked_commits();
597597
self.queue.push(InternalEvent::OpenPopup(
598598
StackablePopupOpen::CompareCommits(
599599
InspectCommitOpen {
600-
commit_id: marked[0].1,
601-
compare_id: Some(marked[1].1),
600+
commit_id: marked[0],
601+
compare_id: Some(marked[1]),
602602
tags: None,
603603
},
604604
),

0 commit comments

Comments
 (0)