Skip to content

Room for potential CI speedups #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AntoniosBarotsis opened this issue Aug 27, 2023 · 3 comments · Fixed by #1852
Closed

Room for potential CI speedups #1844

AntoniosBarotsis opened this issue Aug 27, 2023 · 3 comments · Fixed by #1852
Milestone

Comments

@AntoniosBarotsis
Copy link
Contributor

Looking at a CI run, both build-linux-arm and build-linux-musl don't appear to be using a cache, is this intentional? If not, adding one should reduce the step times by a decent margin. They definitely won't be as quick as the native builds but a gain is a gain 😅

Additionally, there is a wall of deprecation warnings, most of which should be coming from actions-rs/toolchain@v1 which is not maintained anymore, a maintained alternative is https://github.com/dtolnay/rust-toolchain.

Another suggestion would be to perhaps look into rust-cache for caching instead of doing it manually as it comes with some more defaults that might be useful.

@extrawurst
Copy link
Collaborator

Feel free to make PRs so we can compare :)

@AntoniosBarotsis
Copy link
Contributor Author

Will draft something in the upcoming days

@extrawurst extrawurst added this to the v0.24.1 milestone Aug 29, 2023
@extrawurst
Copy link
Collaborator

looking to put this into action in v0.24.1 patch release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants