return instead of if ! for spring-guides#30

glelouet · glelouet · commit e30ee713831a · 2024-05-25T18:41:14.000+02:00
diff --git a/src/main/java/com/example/schedulingtasks/ScheduledTasks.java b/src/main/java/com/example/schedulingtasks/ScheduledTasks.java
@@ -42,8 +42,9 @@ public void reportCurrentTime() {
 
 	@Scheduled(fixedRateString = "${my.app.time.report.cycle:8000}", initialDelayString = "${my.app.time.report.delay:0}")
 	public void reportCurrentTimeParametered() {
-		if (!skipReportTime) {
-			log.info("[parametered] The time is now {}", dateFormat.format(new Date()));
+		if (skipReportTime) {
+			return;
 		}
+		log.info("[parametered] The time is now {}", dateFormat.format(new Date()));
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,9 @@ public void reportCurrentTime() {`
`42`	`42`
`43`	`43`	`@Scheduled(fixedRateString = "${my.app.time.report.cycle:8000}", initialDelayString = "${my.app.time.report.delay:0}")`
`44`	`44`	`public void reportCurrentTimeParametered() {`
`45`		`- if (!skipReportTime) {`
`46`		`- log.info("[parametered] The time is now {}", dateFormat.format(new Date()));`
	`45`	`+ if (skipReportTime) {`
	`46`	`+ return;`
`47`	`47`	`}`
	`48`	`+ log.info("[parametered] The time is now {}", dateFormat.format(new Date()));`
`48`	`49`	`}`
`49`	`50`	`}`