[dart] Change operator== to accept Object

The base method[0] accepts Object, and using dynamic is apparently
hostile to mockito[1], which is used downstream.

[0] https://api.dart.dev/stable/2.12.0/dart-core/Object/operator_equals.html
[1] dart-lang/mockito#354

Change-Id: I0cd6f1a8ad4fccf41f0671d774a0694fa2d28e6a
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/712023
API-Review: Adam Barth <[email protected]>
Fuchsia-Auto-Submit: Tamir Duberstein <[email protected]>
Reviewed-by: Adam Barth <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>

Author: tamird

docs/reference/fidl/bindings/dart-bindings.md

@@ -125,7 +125,7 @@ or every flag set (`$mask`):
 * `String toString()`: Returns a readable representation of the `FileMode`.
 * `FileMode operator |(FileMode other)`: Bitwise or operator.
 * `FileMode operator &(FileMode other)`: Bitwise and operator.
-* `bool operator(dynamic other)`: Equality operator.
+* `bool operator==(Object other)`: Equality operator.
 * `int getUnknownBits()`: Returns only the set bits that are unknown. Always
   returns 0 for [strict][lang-flexible] bits.
 * `bool hasUnknownBits()`: Returns whether this value contains any unknown bits.
@@ -203,7 +203,7 @@ The FIDL toolchain generates a `Color` class with the following methods:
   provided named arguments.
 * `List<Object> get $fields`: Returns a list of fields in declaration order.
 * `String toString()`: Returns a readable string of the `Color`
-* `bool operator==(dynamic other)`: Equality operator that performs a deep
+* `bool operator==(Object other)`: Equality operator that performs a deep
   comparison when compared to another instance of a `Color`.
 
 Example usage:
@@ -241,7 +241,7 @@ As well as a `JsonValue` class with the following methods:
 * `String toString()`: Returns a readable string of the `JsonValue`.
 * `int get $ordinal`: Getter for the underlying [ordinal][union-lexicon] value.
 * `Object get $data`: Getter for the underlying union data.
-* `bool operator ==(dynamic other)`: Equality operator that performs deep
+* `bool operator ==(Object other)`: Equality operator that performs deep
    comparison when compared to another `JsonValue` of the same variant.
 * `fidl.UnknownRawData? get $unknownData`: Returns the bytes and handles of the
   unknown data if this union contains an unknown variant, or `null` otherwise.
@@ -306,7 +306,7 @@ The FIDL toolchain generates a `User` class that defines the following methods:
   to unknown field values (i.e. bytes and handles). The list of handles is
   returned in [traversal order][traversal], and is guaranteed to be empty if the
   table is a [value][lang-resource] type.
-* `bool operator ==(dynamic other)`: Equality operator that performs deep
+* `bool operator ==(Object other)`: Equality operator that performs deep
   comparison when compared to another `User`.
 
 Example usage:

scripts/fxtest/lib/test_names_collector.dart

@@ -270,7 +270,7 @@ class MatchableArgument {
       MatchableArgument._(null, MatchType.unrestricted);
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     return identical(this, other) ||
         (other is MatchableArgument &&
             runtimeType == other.runtimeType &&

sdk/dart/fidl/fidl.api

@@ -34,7 +34,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,
@@ -4320,7 +4320,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,
@@ -4442,7 +4442,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,
@@ -12225,7 +12225,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,

sdk/dart/fidl/lib/src/bits.dart

@@ -12,7 +12,7 @@ abstract class Bits {
   int get $value;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is Bits) {
       return $value == other.$value;
     }

sdk/dart/fidl/lib/src/struct.dart

@@ -18,14 +18,14 @@ abstract class Struct {
   void $encode(Encoder encoder, int offset, int depth);
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) {
       return true;
     }
     if (runtimeType != other.runtimeType) {
       return false;
     }
-    final Struct otherStruct = other;
+    final otherStruct = other as Struct;
     return deepEquals($fields, otherStruct.$fields);
   }
 

sdk/dart/fidl/lib/src/table.dart

@@ -18,14 +18,14 @@ abstract class Table {
   int get hashCode => deepHash($fields.values);
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) {
       return true;
     }
     if (runtimeType != other.runtimeType) {
       return false;
     }
-    final Table otherTable = other;
+    final otherTable = other as Table;
     return deepEquals($fields, otherTable.$fields);
   }
 

sdk/dart/fidl/lib/src/union.dart

@@ -16,14 +16,14 @@ abstract class Union {
   int get hashCode => deepHash([$ordinal, $data]);
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (identical(this, other)) {
       return true;
     }
     if (runtimeType != other.runtimeType) {
       return false;
     }
-    final Union otherUnion = other;
+    final otherUnion = other as Union;
     if ($ordinal != otherUnion.$ordinal) {
       return false;
     }

sdk/dart/fuchsia_scenic_flutter/test/fuchsia_view_connection_test.dart

@@ -404,7 +404,7 @@ class MockViewHolderToken extends Mock implements ViewHolderToken {
   int get hashCode => super.noSuchMethod(Invocation.method(#hashCode, []));
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       super.noSuchMethod(Invocation.method(#==, [other]));
 }
 
@@ -413,7 +413,7 @@ class MockViewportCreationToken extends Mock implements ViewportCreationToken {
   int get hashCode => super.noSuchMethod(Invocation.method(#hashCode, []));
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       super.noSuchMethod(Invocation.method(#==, [other]));
 }
 
@@ -422,7 +422,7 @@ class MockViewRef extends Mock implements ViewRef {
   int get hashCode => super.noSuchMethod(Invocation.method(#hashCode, []));
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       super.noSuchMethod(Invocation.method(#==, [other]));
 }
 
@@ -435,7 +435,7 @@ class MockHandle extends Mock implements Handle {
   int get hashCode => super.noSuchMethod(Invocation.method(#hashCode, []));
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       super.noSuchMethod(Invocation.method(#==, [other]));
 
   @override

sdk/dart/fuchsia_scenic_flutter/test/pointer_injector_test.dart

@@ -170,7 +170,7 @@ class MockViewRef extends Mock implements ViewRef {
   int get hashCode => super.noSuchMethod(Invocation.method(#hashCode, []));
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       super.noSuchMethod(Invocation.method(#==, [other]));
 }
 

sdk/testing/sl4f/client/lib/src/trace_processing/time_delta.dart

@@ -55,7 +55,7 @@ class TimeDelta implements Comparable<TimeDelta> {
   bool operator >=(TimeDelta other) => _delta >= other._delta;
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is TimeDelta && _delta == other._delta;
   @override
   int get hashCode => _delta.hashCode;

sdk/testing/sl4f/client/lib/src/trace_processing/time_point.dart

@@ -30,7 +30,7 @@ class TimePoint implements Comparable<TimePoint> {
   bool operator >=(TimePoint other) => _ticks >= other._ticks;
 
   @override
-  bool operator ==(dynamic other) =>
+  bool operator ==(Object other) =>
       other is TimePoint && _ticks == other._ticks;
   @override
   int get hashCode => _ticks.hashCode;

sdk/testing/sl4f/client/sl4f.api

@@ -7843,7 +7843,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,
@@ -8195,7 +8195,7 @@
                   "isRequiredPositional": true,
                   "name": "other",
                   "type": "SimpleFormalParameterImpl",
-                  "varType": "dynamic"
+                  "varType": "Object"
                 }
               },
               "isAbstract": false,