Skip to content

Flutter (Channel beta), v1.2.1 is released! #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pchampio opened this issue Feb 26, 2019 · 6 comments
Closed

Flutter (Channel beta), v1.2.1 is released! #78

pchampio opened this issue Feb 26, 2019 · 6 comments
Assignees
Labels
embedder Issue concerns the embedder package warning

Comments

@pchampio
Copy link
Member

The Changelog contains 2 Embedder API changes:

#7497 Embedder API: main_path and packages_path in FlutterProjectArgs have been renamed to indicate that they should no longer be provided.
#7567 Embedder API: The FlutterResult type has been renamed to FlutterEngineResult.

@pchampio
Copy link
Member Author

Good news, none of the above changes breaks go-flutter.

@pchampio
Copy link
Member Author

pchampio commented Feb 26, 2019

The following message appear when the go-flutter embedder is started:

[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(95)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(95)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.

The error is not critical.

@pchampio pchampio added embedder Issue concerns the embedder package warning labels Feb 27, 2019
@GeertJohan GeertJohan self-assigned this Mar 4, 2019
@GeertJohan
Copy link
Member

GeertJohan commented Mar 4, 2019

We should probably decide which channel we stick to. I'm usually using the dev channel, which was already at 1.2.2, but that channel is not stable at all.. Perhaps it's good to stay compatible with beta?

@pchampio
Copy link
Member Author

pchampio commented Mar 4, 2019

Tracking Beta is good enough.

@GeertJohan
Copy link
Member

As part of solving this issue, the flutter_embedder.h file should be updated to the upstream version linked to v1.2.1.

@GeertJohan
Copy link
Member

I've already pushed version compatibility information directly to master, PR #81 to update embedder definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedder Issue concerns the embedder package warning
Development

No branches or pull requests

2 participants