Skip to content

Add support for window minimization #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GeertJohan opened this issue Mar 15, 2019 · 2 comments · Fixed by #142
Closed

Add support for window minimization #88

GeertJohan opened this issue Mar 15, 2019 · 2 comments · Fixed by #142
Assignees
@GeertJohan
Labels
embedder Issue concerns the embedder package enhancement New feature or request

Comments

@GeertJohan
Copy link
Member

GeertJohan commented Mar 15, 2019 •
edited
Loading

When the flutter application signals to pop the whole application, we should probably iconify or minimize the application..

SystemNavigator.pop method on flutter/plaform channel:
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformChannel.java#L113

Should be routed to GLFW hide/show or iconify:
https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#Window.Hide
https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#Window.Show
https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#Window.Iconify

And

Callback on focus or iconify changes:
https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#Window.SetFocusCallback
https://godoc.org/github.com/go-gl/glfw/v3.2/glfw#Window.SetIconifyCallback

Should be routed to LifecycleChannel:
https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java
@GeertJohan
Copy link
Member Author

This could be part of a bigger effort to separate GLFW as a renderer, which would then implement platform channels.

@GeertJohan GeertJohan self-assigned this Mar 15, 2019
@GeertJohan GeertJohan added enhancement New feature or request embedder Issue concerns the embedder package labels Mar 15, 2019
@GeertJohan GeertJohan pinned this issue Apr 5, 2019
@GeertJohan
Copy link
Member Author

Starting work on this now.

@GeertJohan GeertJohan mentioned this issue May 18, 2019
Merged
@GeertJohan GeertJohan unpinned this issue May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeertJohan GeertJohan

Labels
embedder Issue concerns the embedder package enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial implementation for system navigator pop event go-flutter-desktop/go-flutter
1 participant
@GeertJohan