Skip to content

Commit 5320e1b

Browse files
committed
plumbing: surface transport configuration errors
Signed-off-by: Hidde Beydals <[email protected]>
1 parent 9bbc93b commit 5320e1b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Diff for: plumbing/transport/http/common.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,9 @@ func newSession(c *client, ep *transport.Endpoint, auth transport.AuthMethod) (*
260260
}
261261

262262
transport = tr.Clone()
263-
configureTransport(transport, ep)
263+
if err := configureTransport(transport, ep); err != nil {
264+
return nil, err
265+
}
264266
} else {
265267
transportOpts := transportOptions{
266268
clientCert: string(ep.ClientCert),
@@ -280,7 +282,9 @@ func newSession(c *client, ep *transport.Endpoint, auth transport.AuthMethod) (*
280282

281283
if !found {
282284
transport = c.client.Transport.(*http.Transport).Clone()
283-
configureTransport(transport, ep)
285+
if err := configureTransport(transport, ep); err != nil {
286+
return nil, err
287+
}
284288
c.addTransport(transportOpts, transport)
285289
}
286290
}

0 commit comments

Comments
 (0)