plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

tylerchr · 2022-04-22T06:31:23Z

Previously, calling Set($CAPABILITY, ...) on a capability.List where $CAPABILITY
was already present would correctly replace the existing value of that capability, but
would also result in that capability being listed twice in the internal l.sort slice.
This manifested publicly when the List was encoded as the same capability appearing
twice with the same value in the encoded output.

A new test case is added. Prior to the fix, the new test case failed like this:

$ go test -v
=== RUN   Test

----------------------------------------------------------------------
FAIL: list_test.go:125: SuiteCapabilities.TestSetDuplicate

list_test.go:133:
    c.Assert(cap.String(), check.Equals, "agent=bar")
... obtained string = "agent=bar agent=bar"
... expected string = "agent=bar"

OOPS: 23 passed, 1 FAILED

…y value. Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY` was already present would correctly replace the existing value of that capability, but would also result in that capability being listed twice in the internal `l.sort` slice. This manifested publicly when the `List` was encoded as the same capability appearing twice with the same value in the encoded output.

…y value. (go-git#521) Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY` was already present would correctly replace the existing value of that capability, but would also result in that capability being listed twice in the internal `l.sort` slice. This manifested publicly when the `List` was encoded as the same capability appearing twice with the same value in the encoded output.

…y value. (go-git#521) Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY` was already present would correctly replace the existing value of that capability, but would also result in that capability being listed twice in the internal `l.sort` slice. This manifested publicly when the `List` was encoded as the same capability appearing twice with the same value in the encoded output. (cherry picked from commit 69aa78a)

…y value. (go-git#521) Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY` was already present would correctly replace the existing value of that capability, but would also result in that capability being listed twice in the internal `l.sort` slice. This manifested publicly when the `List` was encoded as the same capability appearing twice with the same value in the encoded output.

mcuadros merged commit 69aa78a into go-git:master Apr 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

tylerchr commented Apr 22, 2022

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

plumbing: packp, Avoid duplicate encoding when overriding a Capability value. #521

Conversation

tylerchr commented Apr 22, 2022