Skip to content

Commit 0271114

Browse files
denyskondenyskon
authored
cleanup repo details icons/labels (#27644)
Fix #27596 Change confusing behavior when showing information about a repo via labels and icons. Implement changes proposed by @lng2020 in #27627 (review).
1 parent 6c501b1 commit 0271114

File tree

5 files changed

+28
-60
lines changed

5 files changed

+28
-60
lines changed

‎options/locale/locale_en-US.ini

+1-3
Original file line numberDiff line numberDiff line change
@@ -1030,10 +1030,8 @@ transfer.no_permission_to_reject = You do not have permission to reject this tra
10301030

10311031
desc.private = Private
10321032
desc.public = Public
1033-
desc.private_template = Private template
1034-
desc.public_template = Template
1033+
desc.template = Template
10351034
desc.internal = Internal
1036-
desc.internal_template = Internal template
10371035
desc.archived = Archived
10381036

10391037
template.items = Template Items

‎templates/admin/repo/list.tmpl

+11-18
Original file line numberDiff line numberDiff line change
@@ -55,29 +55,22 @@
5555
<td>
5656
<a href="{{.Link}}">{{.Name}}</a>
5757
{{if .IsArchived}}
58-
<span class="ui basic mini label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
58+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
5959
{{end}}
60-
{{if .IsTemplate}}
61-
{{if .IsPrivate}}
62-
<span class="ui basic mini label">{{ctx.Locale.Tr "repo.desc.private_template"}}</span>
63-
{{else}}
64-
{{if .Owner.Visibility.IsPrivate}}
65-
<span class="ui basic mini label">{{ctx.Locale.Tr "repo.desc.internal_template"}}</span>
66-
{{end}}
67-
{{end}}
60+
{{if .IsPrivate}}
61+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
6862
{{else}}
69-
{{if .IsPrivate}}
70-
<span class="ui basic mini label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
71-
{{else}}
72-
{{if .Owner.Visibility.IsPrivate}}
73-
<span class="ui basic mini label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
74-
{{end}}
63+
{{if .Owner.Visibility.IsPrivate}}
64+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
7565
{{end}}
7666
{{end}}
77-
{{if .IsFork}}
78-
{{svg "octicon-repo-forked"}}
79-
{{else if .IsMirror}}
67+
{{if .IsTemplate}}
68+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.template"}}</span>
69+
{{end}}
70+
{{if .IsMirror}}
8071
{{svg "octicon-mirror"}}
72+
{{else if .IsFork}}
73+
{{svg "octicon-repo-forked"}}
8174
{{end}}
8275
</td>
8376
<td>{{.NumWatches}}</td>

‎templates/explore/repo_list.tmpl

+7-19
Original file line numberDiff line numberDiff line change
@@ -14,29 +14,17 @@
1414
{{if .IsArchived}}
1515
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
1616
{{end}}
17-
{{if .IsTemplate}}
18-
{{if .IsPrivate}}
19-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private_template"}}</span>
20-
{{else}}
21-
{{if .Owner.Visibility.IsPrivate}}
22-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal_template"}}</span>
23-
{{end}}
24-
{{end}}
17+
{{if .IsPrivate}}
18+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
2519
{{else}}
26-
{{if .IsPrivate}}
27-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
28-
{{else}}
29-
{{if .Owner.Visibility.IsPrivate}}
30-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
31-
{{end}}
20+
{{if .Owner.Visibility.IsPrivate}}
21+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
3222
{{end}}
3323
{{end}}
24+
{{if .IsTemplate}}
25+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.template"}}</span>
26+
{{end}}
3427
</span>
35-
{{if .IsFork}}
36-
<span data-tooltip-content="{{ctx.Locale.Tr "repo.fork"}}">{{svg "octicon-repo-forked"}}</span>
37-
{{else if .IsMirror}}
38-
<span data-tooltip-content="{{ctx.Locale.Tr "mirror"}}">{{svg "octicon-mirror"}}</span>
39-
{{end}}
4028
</div>
4129
<div class="flex-item-trailing">
4230
{{if .PrimaryLanguage}}

‎templates/repo/header.tmpl

+9-16
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,18 @@
1111
<div class="gt-mx-2">/</div>
1212
<a href="{{$.RepoLink}}">{{.Name}}</a>
1313
<div class="labels gt-df gt-ac gt-fw">
14-
{{if .IsTemplate}}
15-
{{if .IsPrivate}}
16-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private_template"}}</span>
17-
{{else}}
18-
{{if .Owner.Visibility.IsPrivate}}
19-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal_template"}}</span>
20-
{{end}}
21-
{{end}}
14+
{{if .IsArchived}}
15+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
16+
{{end}}
17+
{{if .IsPrivate}}
18+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
2219
{{else}}
23-
{{if .IsPrivate}}
24-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.private"}}</span>
25-
{{else}}
26-
{{if .Owner.Visibility.IsPrivate}}
27-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
28-
{{end}}
20+
{{if .Owner.Visibility.IsPrivate}}
21+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.internal"}}</span>
2922
{{end}}
3023
{{end}}
31-
{{if .IsArchived}}
32-
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.archived"}}</span>
24+
{{if .IsTemplate}}
25+
<span class="ui basic label">{{ctx.Locale.Tr "repo.desc.template"}}</span>
3326
{{end}}
3427
</div>
3528
{{if $.EnableFeed}}

‎templates/repo/icon.tmpl

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
{{$avatarLink := (.RelAvatarLink ctx)}}
22
{{if $avatarLink}}
33
<img class="ui avatar gt-vm" src="{{$avatarLink}}" width="32" height="32" alt="{{.FullName}}">
4-
{{else if $.IsTemplate}}
5-
{{svg "octicon-repo-template" 32}}
6-
{{else if $.IsPrivate}}
7-
{{svg "octicon-lock" 32}}
84
{{else if $.IsMirror}}
95
{{svg "octicon-mirror" 32}}
106
{{else if $.IsFork}}

0 commit comments

Comments
 (0)