Only log Error on getLastCommitStatus error to let pull list still be visible (#15716)

6543 · web-flow · commit 1cd301796c23 · 2021-05-04T14:03:02.000+02:00
diff --git a/services/pull/pull.go b/services/pull/pull.go
@@ -677,7 +677,8 @@ func GetIssuesLastCommitStatus(issues models.IssueList) (map[int64]*models.Commi
 
 		status, err := getLastCommitStatus(gitRepo, issue.PullRequest)
 		if err != nil {
-			return nil, err
+			log.Error("getLastCommitStatus: cant get last commit of pull [%d]: %v", issue.PullRequest.ID, err)
+			continue
 		}
 		res[issue.PullRequest.ID] = status
 	}

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,8 @@ func GetIssuesLastCommitStatus(issues models.IssueList) (map[int64]*models.Commi`
`677`	`677`
`678`	`678`	`status, err := getLastCommitStatus(gitRepo, issue.PullRequest)`
`679`	`679`	`if err != nil {`
`680`		`- return nil, err`
	`680`	`+ log.Error("getLastCommitStatus: cant get last commit of pull [%d]: %v", issue.PullRequest.ID, err)`
	`681`	`+ continue`
`681`	`682`	`}`
`682`	`683`	`res[issue.PullRequest.ID] = status`
`683`	`684`	`}`