Skip to content

Commit 4f3253f

Browse files
wxiaoguangGiteaBotsilverwind
authored
Revert overflow: overlay (revert #21850) (#25231)
It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. --------- Co-authored-by: Giteabot <[email protected]> Co-authored-by: silverwind <[email protected]>
1 parent 8228751 commit 4f3253f

File tree

5 files changed

+7345
-16
lines changed

5 files changed

+7345
-16
lines changed

web_src/css/base.css

+3-14
Original file line numberDiff line numberDiff line change
@@ -266,19 +266,11 @@ body {
266266
color: var(--color-text);
267267
background-color: var(--color-body);
268268
tab-size: var(--tab-size);
269-
overflow-y: auto;
270269
display: flex;
271270
flex-direction: column;
272271
overflow-wrap: break-word;
273272
}
274273

275-
@supports (overflow: overlay) {
276-
body {
277-
overflow: overlay; /* stylelint-disable-line */
278-
scrollbar-gutter: stable;
279-
}
280-
}
281-
282274
table {
283275
border-collapse: collapse;
284276
}
@@ -910,7 +902,7 @@ img.ui.avatar,
910902
/* overwrite semantic width of containers inside the main page content div (div with class "page-content") */
911903
.page-content .ui.ui.ui.container:not(.fluid) {
912904
width: 1280px;
913-
max-width: calc(100vw - 64px);
905+
max-width: calc(100% - 64px);
914906
margin-left: auto;
915907
margin-right: auto;
916908
}
@@ -922,8 +914,7 @@ img.ui.avatar,
922914
/* enable fluid page widths for medium size viewports */
923915
@media (min-width: 768px) and (max-width: 1200px) {
924916
.page-content .ui.ui.ui.container:not(.fluid) {
925-
width: calc(100vw - 32px);
926-
max-width: calc(100vw - 32px);
917+
max-width: calc(100% - 32px);
927918
}
928919
.ui.container.fluid.padded {
929920
padding: 0 16px;
@@ -932,8 +923,7 @@ img.ui.avatar,
932923

933924
@media (max-width: 767.98px) {
934925
.page-content .ui.ui.ui.container:not(.fluid) {
935-
width: calc(100vw - 16px);
936-
max-width: calc(100vw - 16px);
926+
max-width: calc(100% - 16px);
937927
}
938928
.ui.container.fluid.padded {
939929
padding: 0 8px;
@@ -945,7 +935,6 @@ img.ui.avatar,
945935
align-items: center;
946936
background: var(--color-nav-bg);
947937
border-bottom: 1px solid var(--color-secondary);
948-
width: 100vw;
949938
min-height: 52px;
950939
margin: 0 !important;
951940
}

web_src/fomantic/.npmrc

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
audit=false
22
fund=false
33
update-notifier=false
4-
package-lock=false
4+
package-lock=true
5+
save-exact=true
6+
lockfile-version=3
57
optional=false

web_src/fomantic/_site/globals/site.variables

+1
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@
88
@variationPopupTooltip: false;
99
@linkHoverUnderline: underline;
1010
@variationButtonSocial: false;
11+
@pageOverflowX: visible;

web_src/fomantic/build/semantic.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)