Skip to content

Commit 51db7b0

Browse files
authored
Release page show all tags in compare dropdown (#20070) (#20071)
Backport #20070 Just get all tags when creating the compare dropdown. (Also updates the changelog.) Fix #19936
1 parent a7b1e20 commit 51db7b0

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

Diff for: CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ This changelog goes through all the changes that have been made in each release
44
without substantial changes to our git log; to see the highlights of what has
55
been added to each release, please refer to the [blog](https://blog.gitea.io).
66

7-
## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/1.16.9) - 2022-06-20
7+
## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/v1.16.9) - 2022-06-21
88

99
* BUGFIXES
10+
* Release page show all tags in compare dropdown (#20070) (#20071)
1011
* Fix permission check for delete tag (#19985) (#20001)
1112
* Only log non ErrNotExist errors in git.GetNote (#19884) (#19905)
1213
* Use exact search instead of fuzzy search for branch filter dropdown (#19885) (#19893)

Diff for: routers/web/repo/release.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,14 @@ func releasesOrTags(ctx *context.Context, isTagList bool) {
9898
listOptions.PageSize = setting.API.MaxResponseItems
9999
}
100100

101-
tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd())
101+
// TODO(20073) tags are used for compare feature witch needs all tags
102+
// filtering is doen at the client side atm
103+
tagListStart, tagListEnd := 0, 0
104+
if isTagList {
105+
tagListStart, tagListEnd = listOptions.GetStartEnd()
106+
}
107+
108+
tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)
102109
if err != nil {
103110
ctx.ServerError("GetTags", err)
104111
return

0 commit comments

Comments
 (0)