Skip to content

Commit 53b5522

Browse files
authored
Ignore useless error message "broken pipe" (#30801)
Fix #30792
1 parent c4e8754 commit 53b5522

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

routers/api/packages/maven/maven.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,7 @@ func serveMavenMetadata(ctx *context.Context, params parameters) {
140140
ctx.Resp.Header().Set("Content-Length", strconv.Itoa(len(xmlMetadataWithHeader)))
141141
ctx.Resp.Header().Set("Content-Type", contentTypeXML)
142142

143-
if _, err := ctx.Resp.Write(xmlMetadataWithHeader); err != nil {
144-
log.Error("write bytes failed: %v", err)
145-
}
143+
_, _ = ctx.Resp.Write(xmlMetadataWithHeader)
146144
}
147145

148146
func servePackageFile(ctx *context.Context, params parameters, serveContent bool) {

services/context/base.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,7 @@ func (b *Base) plainTextInternal(skip, status int, bs []byte) {
234234
b.Resp.Header().Set("Content-Type", "text/plain;charset=utf-8")
235235
b.Resp.Header().Set("X-Content-Type-Options", "nosniff")
236236
b.Resp.WriteHeader(status)
237-
if _, err := b.Resp.Write(bs); err != nil {
238-
log.ErrorWithSkip(skip, "plainTextInternal (status=%d): write bytes failed: %v", status, err)
239-
}
237+
_, _ = b.Resp.Write(bs)
240238
}
241239

242240
// PlainTextBytes renders bytes as plain text

services/context/context_response.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"path"
1414
"strconv"
1515
"strings"
16+
"syscall"
1617
"time"
1718

1819
user_model "code.gitea.io/gitea/models/user"
@@ -77,7 +78,7 @@ func (ctx *Context) HTML(status int, name base.TplName) {
7778
}
7879

7980
err := ctx.Render.HTML(ctx.Resp, status, string(name), ctx.Data, ctx.TemplateContext)
80-
if err == nil {
81+
if err == nil || errors.Is(err, syscall.EPIPE) {
8182
return
8283
}
8384

0 commit comments

Comments
 (0)