Skip to content

Commit 78c48d8

Browse files
authored
Fix can not select team reviewers when reviewers is empty (#29174)
Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/b29e9c0c-f0fc-454f-b82d-ff9688d9e871) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/a982f7c6-4911-4951-91a5-4bb347e866f9) Is this a bug? Maybe we don't need to fix this, as it only occurs when there's only one user in the organization. 🤔
1 parent 1c14cd0 commit 78c48d8

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: templates/repo/issue/view_content/sidebar.tmpl

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
{{template "repo/issue/branch_selector_field" .}}
33
{{if .Issue.IsPull}}
44
<input id="reviewer_id" name="reviewer_id" type="hidden" value="{{.reviewer_id}}">
5-
<div class="ui {{if or (not .Reviewers) (not .CanChooseReviewer) .Repository.IsArchived}}disabled{{end}} floating jump select-reviewers-modify dropdown">
5+
<div class="ui {{if or (and (not .Reviewers) (not .TeamReviewers)) (not .CanChooseReviewer) .Repository.IsArchived}}disabled{{end}} floating jump select-reviewers-modify dropdown">
66
<a class="text gt-df gt-ac muted">
77
<strong>{{ctx.Locale.Tr "repo.issues.review.reviewers"}}</strong>
88
{{if and .CanChooseReviewer (not .Repository.IsArchived)}}
@@ -29,7 +29,9 @@
2929
{{end}}
3030
{{end}}
3131
{{if .TeamReviewers}}
32-
<div class="divider"></div>
32+
{{if .Reviewers}}
33+
<div class="divider"></div>
34+
{{end}}
3335
{{range .TeamReviewers}}
3436
{{if .Team}}
3537
<a class="{{if not .CanChange}}ui{{end}} item {{if .Checked}}checked{{end}} {{if not .CanChange}}ban-change{{end}}" href="#" data-id="{{.ItemID}}" data-id-selector="#review_request_team_{{.Team.ID}}" {{if not .CanChange}} data-tooltip-content="{{ctx.Locale.Tr "repo.issues.remove_request_review_block"}}"{{end}}>

0 commit comments

Comments
 (0)