Skip to content

Commit 7b60d47

Browse files
authored
Log STDERR of external renderer when it fails (#22442) (#22444)
Backport #22442.
1 parent 265d438 commit 7b60d47

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: modules/markup/external/external.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
package external
66

77
import (
8+
"bytes"
89
"fmt"
910
"io"
1011
"os"
@@ -133,11 +134,13 @@ func (p *Renderer) Render(ctx *markup.RenderContext, input io.Reader, output io.
133134
if !p.IsInputFile {
134135
cmd.Stdin = input
135136
}
137+
var stderr bytes.Buffer
136138
cmd.Stdout = output
139+
cmd.Stderr = &stderr
137140
process.SetSysProcAttribute(cmd)
138141

139142
if err := cmd.Run(); err != nil {
140-
return fmt.Errorf("%s render run command %s %v failed: %w", p.Name(), commands[0], args, err)
143+
return fmt.Errorf("%s render run command %s %v failed: %w\nStderr: %s", p.Name(), commands[0], args, err, stderr.String())
141144
}
142145
return nil
143146
}

0 commit comments

Comments
 (0)