Skip to content

Commit 8703b6c

Browse files
yp05327GiteaBot
andauthored
Improve clickable area in repo action view page (#26115)
Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/52e4dda1-0221-440b-93e1-242db8bd5885) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/dda5e72b-205e-44f7-b4a9-83703021f2d1) In current design, the clickable area is too small, and it is hard to find the correct clickable area as the area with background color (div with class name `job-brief-item selected`) is bigger than it. --------- Co-authored-by: Giteabot <[email protected]>
1 parent c7fd9ad commit 8703b6c

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

web_src/js/components/RepoActionView.vue

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@
3232
<div class="action-view-left">
3333
<div class="job-group-section">
3434
<div class="job-brief-list">
35-
<div class="job-brief-item" :class="parseInt(jobIndex) === index ? 'selected' : ''" v-for="(job, index) in run.jobs" :key="job.id" @mouseenter="onHoverRerunIndex = job.id" @mouseleave="onHoverRerunIndex = -1">
36-
<a class="job-brief-link" :href="run.link+'/jobs/'+index">
35+
<a class="job-brief-item" :href="run.link+'/jobs/'+index" :class="parseInt(jobIndex) === index ? 'selected' : ''" v-for="(job, index) in run.jobs" :key="job.id" @mouseenter="onHoverRerunIndex = job.id" @mouseleave="onHoverRerunIndex = -1">
36+
<div class="job-brief-item-left">
3737
<ActionRunStatus :locale-status="locale.status[job.status]" :status="job.status"/>
3838
<span class="job-brief-name gt-mx-3 gt-ellipsis">{{ job.name }}</span>
39-
</a>
40-
<span class="job-brief-info">
39+
</div>
40+
<span class="job-brief-item-right">
4141
<SvgIcon name="octicon-sync" role="button" :data-tooltip-content="locale.rerun" class="job-brief-rerun gt-mx-3" @click="rerunJob(index)" v-if="job.canRerun && onHoverRerunIndex === job.id"/>
4242
<span class="step-summary-duration">{{ job.duration }}</span>
4343
</span>
44-
</div>
44+
</a>
4545
</div>
4646
</div>
4747
<div class="job-artifacts" v-if="artifacts.length > 0">
@@ -575,6 +575,7 @@ export function initRepositoryActionView() {
575575
flex-wrap: nowrap;
576576
justify-content: space-between;
577577
align-items: center;
578+
color: var(--color-text);
578579
}
579580
580581
.job-brief-item:hover {
@@ -599,28 +600,23 @@ export function initRepositoryActionView() {
599600
transform: scale(130%);
600601
}
601602
602-
.job-brief-item .job-brief-link {
603+
.job-brief-item .job-brief-item-left {
603604
display: flex;
604605
width: 100%;
605606
min-width: 0;
606607
}
607608
608-
.job-brief-item .job-brief-link span {
609+
.job-brief-item .job-brief-item-left span {
609610
display: flex;
610611
align-items: center;
611612
}
612613
613-
.job-brief-item .job-brief-link .job-brief-name {
614+
.job-brief-item .job-brief-item-left .job-brief-name {
614615
display: block;
615616
width: 70%;
616-
color: var(--color-text);
617-
}
618-
619-
.job-brief-item .job-brief-link:hover {
620-
text-decoration: none;
621617
}
622618
623-
.job-brief-item .job-brief-info {
619+
.job-brief-item .job-brief-item-right {
624620
display: flex;
625621
align-items: center;
626622
}

0 commit comments

Comments
 (0)