Skip to content

Commit 8fa54d0

Browse files
authored
Fix notification and stopwatch empty states (#22845)
Previous solution was relying on fomantic selector `.ui.label.hidden` to hide the elements in their empty state, but this doesn't work any more with the removal of the `label` class. Instead, introduce a standalone CSS rule for the `hidden` class, which is universally usable as a single class. We can unfortunately not use the existing `hide` class because without the `!important`, it does not have enough specificity to win against fomantic's `.ui.menu:not(.vertical) .item {display: flex}` rule. Followup and fixes regression from #22169. Before: <img width="98" alt="image" src="https://user-images.githubusercontent.com/115237/217959380-d3279ff3-526a-4ac4-9a18-3ab7c9ae91dd.png"> After: <img width="77" alt="image" src="https://user-images.githubusercontent.com/115237/217959463-44852716-cb25-4110-8481-668842ad4454.png">
1 parent 2152c4e commit 8fa54d0

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Diff for: web_src/less/_base.less

+1
Original file line numberDiff line numberDiff line change
@@ -1803,6 +1803,7 @@ footer {
18031803
}
18041804
}
18051805

1806+
/* TODO: remove in favor of .hidden helper */
18061807
.hide {
18071808
display: none;
18081809

Diff for: web_src/less/helpers.less

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
/* below class names match Tailwind CSS */
2323
.pointer-events-none { pointer-events: none !important; }
2424
.relative { position: relative !important; }
25+
.hidden { display: none !important; }
2526

2627
.mono {
2728
font-family: var(--fonts-monospace) !important;

0 commit comments

Comments
 (0)