Skip to content

Commit 902a749

Browse files
ethantkoeniglunny
authored andcommitted
Fix fast-forward PR bug (#1989)
1 parent 826c606 commit 902a749

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

models/pull.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -515,11 +515,11 @@ func (pr *PullRequest) getMergeCommit() (*git.Commit, error) {
515515
mergeCommit, stderr, err := process.GetManager().ExecDirEnv(-1, "", fmt.Sprintf("isMerged (git rev-list --ancestry-path --merges --reverse): %d", pr.BaseRepo.ID),
516516
[]string{"GIT_INDEX_FILE=" + indexTmpPath, "GIT_DIR=" + pr.BaseRepo.RepoPath()},
517517
"git", "rev-list", "--ancestry-path", "--merges", "--reverse", cmd)
518-
if err == nil && len(mergeCommit) != 40 {
519-
err = fmt.Errorf("unexpected length of output (got:%d bytes) '%s'", len(mergeCommit), mergeCommit)
520-
}
521518
if err != nil {
522519
return nil, fmt.Errorf("git rev-list --ancestry-path --merges --reverse: %v %v", stderr, err)
520+
} else if len(mergeCommit) < 40 {
521+
// PR was fast-forwarded, so just use last commit of PR
522+
mergeCommit = commitID[:40]
523523
}
524524

525525
gitRepo, err := git.OpenRepository(pr.BaseRepo.RepoPath())

0 commit comments

Comments
 (0)