Close the temp file when dumping database to make the temp file can be deleted on Windows (#23249) (#23251)

GiteaBot · wxiaoguang · web-flow · commit 9843a0b741ae · 2023-03-02T11:47:07.000-05:00
Backport #23249 There was no `dbDump.Close()` before, Windows doesn't like to delete opened files. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
diff --git a/cmd/dump.go b/cmd/dump.go
@@ -272,6 +272,7 @@ func runDump(ctx *cli.Context) error {
 		fatal("Failed to create tmp file: %v", err)
 	}
 	defer func() {
+		_ = dbDump.Close()
 		if err := util.Remove(dbDump.Name()); err != nil {
 			log.Warn("Unable to remove temporary file: %s: Error: %v", dbDump.Name(), err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -272,6 +272,7 @@ func runDump(ctx *cli.Context) error {`
`272`	`272`	`fatal("Failed to create tmp file: %v", err)`
`273`	`273`	`}`
`274`	`274`	`defer func() {`
	`275`	`+ _ = dbDump.Close()`
`275`	`276`	`if err := util.Remove(dbDump.Name()); err != nil {`
`276`	`277`	`log.Warn("Unable to remove temporary file: %s: Error: %v", dbDump.Name(), err)`
`277`	`278`	`}`