Skip to content

Commit 9892bb1

Browse files
committed
fix test
1 parent c97d8ed commit 9892bb1

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tests/integration/api_packages_swift_test.go

+5-4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
"code.gitea.io/gitea/tests"
2424

2525
"github.com/stretchr/testify/assert"
26+
"github.com/stretchr/testify/require"
2627
)
2728

2829
func TestPackageSwift(t *testing.T) {
@@ -239,9 +240,9 @@ func TestPackageSwift(t *testing.T) {
239240

240241
pvs, err := packages.GetVersionsByPackageType(db.DefaultContext, user.ID, packages.TypeSwift)
241242
assert.NoError(t, err)
242-
assert.Len(t, pvs, 2)
243-
244-
pd, err := packages.GetPackageDescriptor(db.DefaultContext, pvs[1])
243+
require.Len(t, pvs, 2) // FIXME: this test is not right, it's unable to run separately, it depends on the previous one to have an older package existing
244+
thisPackageVersion := pvs[0]
245+
pd, err := packages.GetPackageDescriptor(db.DefaultContext, thisPackageVersion)
245246
assert.NoError(t, err)
246247
assert.NotNil(t, pd.SemVer)
247248
assert.Equal(t, packageID, pd.Package.Name)
@@ -255,7 +256,7 @@ func TestPackageSwift(t *testing.T) {
255256
assert.Len(t, pd.VersionProperties, 1)
256257
assert.Equal(t, packageRepositoryURL, pd.VersionProperties.GetByName(swift_module.PropertyRepositoryURL))
257258

258-
pfs, err := packages.GetFilesByVersionID(db.DefaultContext, pvs[1].ID)
259+
pfs, err := packages.GetFilesByVersionID(db.DefaultContext, thisPackageVersion.ID)
259260
assert.NoError(t, err)
260261
assert.Len(t, pfs, 1)
261262
assert.Equal(t, fmt.Sprintf("%s-%s.zip", packageName, packageVersion2), pfs[0].Name)

0 commit comments

Comments
 (0)