Fix invalid issue branch reference if not specified in template

brechtvl · brechtvl · commit a61f5cae3feb · 2023-01-18T16:00:39.000+01:00
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -784,8 +784,10 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles
 			}
 
 		}
-		if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
-			template.Ref = git.BranchPrefix + template.Ref
+		if template.Ref != "" {
+			if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
+				template.Ref = git.BranchPrefix + template.Ref
+			}
 		}
 		ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0
 		ctx.Data["label_ids"] = strings.Join(labelIDs, ",")

Original file line number	Diff line number	Diff line change
`@@ -784,8 +784,10 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles`
`784`	`784`	`}`
`785`	`785`
`786`	`786`	`}`
`787`		`- if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
`788`		`- template.Ref = git.BranchPrefix + template.Ref`
	`787`	`+ if template.Ref != "" {`
	`788`	`+ if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
	`789`	`+ template.Ref = git.BranchPrefix + template.Ref`
	`790`	`+ }`
`789`	`791`	`}`
`790`	`792`	`ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0`
`791`	`793`	`ctx.Data["label_ids"] = strings.Join(labelIDs, ",")`