Skip to content

Commit a8534ac

Browse files
authored
Fix permission check on issue/pull lock (#22114)
Fix #22110
1 parent e23ad87 commit a8534ac

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Diff for: routers/web/web.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,6 @@ func RegisterRoutes(m *web.Route) {
599599
reqRepoReleaseWriter := context.RequireRepoWriter(unit.TypeReleases)
600600
reqRepoReleaseReader := context.RequireRepoReader(unit.TypeReleases)
601601
reqRepoWikiWriter := context.RequireRepoWriter(unit.TypeWiki)
602-
reqRepoIssueWriter := context.RequireRepoWriter(unit.TypeIssues)
603602
reqRepoIssueReader := context.RequireRepoReader(unit.TypeIssues)
604603
reqRepoPullsReader := context.RequireRepoReader(unit.TypePullRequests)
605604
reqRepoIssuesOrPullsWriter := context.RequireRepoWriterOr(unit.TypeIssues, unit.TypePullRequests)
@@ -893,8 +892,8 @@ func RegisterRoutes(m *web.Route) {
893892
})
894893
})
895894
m.Post("/reactions/{action}", bindIgnErr(forms.ReactionForm{}), repo.ChangeIssueReaction)
896-
m.Post("/lock", reqRepoIssueWriter, bindIgnErr(forms.IssueLockForm{}), repo.LockIssue)
897-
m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue)
895+
m.Post("/lock", reqRepoIssuesOrPullsWriter, bindIgnErr(forms.IssueLockForm{}), repo.LockIssue)
896+
m.Post("/unlock", reqRepoIssuesOrPullsWriter, repo.UnlockIssue)
898897
m.Post("/delete", reqRepoAdmin, repo.DeleteIssue)
899898
}, context.RepoMustNotBeArchived())
900899
m.Group("/{index}", func() {

0 commit comments

Comments
 (0)