Skip to content

Commit a933423

Browse files
committed
add context to remaining branch commands
1 parent bd41dd4 commit a933423

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

modules/git/repo_branch.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -130,20 +130,20 @@ func (repo *Repository) CreateBranch(ctx context.Context, branch, oldbranchOrCom
130130
}
131131

132132
// AddRemote adds a new remote to repository.
133-
func (repo *Repository) AddRemote(name, url string, fetch bool) error {
133+
func (repo *Repository) AddRemote(ctx context.Context, name, url string, fetch bool) error {
134134
cmd := NewCommand("remote", "add")
135135
if fetch {
136136
cmd.AddArguments("-f")
137137
}
138138
cmd.AddDynamicArguments(name, url)
139139

140-
_, _, err := cmd.RunStdString(repo.Ctx, &RunOpts{Dir: repo.Path})
140+
_, _, err := cmd.RunStdString(ctx, &RunOpts{Dir: repo.Path})
141141
return err
142142
}
143143

144144
// RemoveRemote removes a remote from repository.
145-
func (repo *Repository) RemoveRemote(name string) error {
146-
_, _, err := NewCommand("remote", "rm").AddDynamicArguments(name).RunStdString(repo.Ctx, &RunOpts{Dir: repo.Path})
145+
func (repo *Repository) RemoveRemote(ctx context.Context, name string) error {
146+
_, _, err := NewCommand("remote", "rm").AddDynamicArguments(name).RunStdString(ctx, &RunOpts{Dir: repo.Path})
147147
return err
148148
}
149149

@@ -153,7 +153,7 @@ func (branch *Branch) GetCommit() (*Commit, error) {
153153
}
154154

155155
// RenameBranch rename a branch
156-
func (repo *Repository) RenameBranch(from, to string) error {
157-
_, _, err := NewCommand("branch", "-m").AddDynamicArguments(from, to).RunStdString(repo.Ctx, &RunOpts{Dir: repo.Path})
156+
func (repo *Repository) RenameBranch(ctx context.Context, from, to string) error {
157+
_, _, err := NewCommand("branch", "-m").AddDynamicArguments(from, to).RunStdString(ctx, &RunOpts{Dir: repo.Path})
158158
return err
159159
}

modules/git/repo_compare.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ func (repo *Repository) GetCompareInfo(ctx context.Context, basePath, baseBranch
6060
if repo.Path != basePath {
6161
// Add a temporary remote
6262
tmpRemote = strconv.FormatInt(time.Now().UnixNano(), 10)
63-
if err = repo.AddRemote(tmpRemote, basePath, false); err != nil {
63+
if err = repo.AddRemote(ctx, tmpRemote, basePath, false); err != nil {
6464
return nil, fmt.Errorf("AddRemote: %w", err)
6565
}
6666
defer func() {
67-
if err := repo.RemoveRemote(tmpRemote); err != nil {
67+
if err := repo.RemoveRemote(ctx, tmpRemote); err != nil {
6868
logger.Error("GetPullRequestInfo: RemoveRemote: %v", err)
6969
}
7070
}()

services/issue/pull.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ import (
2121
func getMergeBase(ctx context.Context, repo *git.Repository, pr *issues_model.PullRequest, baseBranch, headBranch string) (string, error) {
2222
// Add a temporary remote
2323
tmpRemote := fmt.Sprintf("mergebase-%d-%d", pr.ID, time.Now().UnixNano())
24-
if err := repo.AddRemote(tmpRemote, repo.Path, false); err != nil {
24+
if err := repo.AddRemote(ctx, tmpRemote, repo.Path, false); err != nil {
2525
return "", fmt.Errorf("AddRemote: %w", err)
2626
}
2727
defer func() {
28-
if err := repo.RemoveRemote(tmpRemote); err != nil {
28+
if err := repo.RemoveRemote(ctx, tmpRemote); err != nil {
2929
log.Error("getMergeBase: RemoveRemote: %v", err)
3030
}
3131
}()

services/migrations/dump.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ func (g *RepositoryDumper) handlePullRequest(ctx context.Context, pr *base.PullR
507507
remote = "head-pr-" + strconv.FormatInt(pr.Number, 10)
508508
}
509509
// ... now add the remote
510-
err := g.gitRepo.AddRemote(remote, pr.Head.CloneURL, true)
510+
err := g.gitRepo.AddRemote(ctx, remote, pr.Head.CloneURL, true)
511511
if err != nil {
512512
log.Error("PR #%d in %s/%s AddRemote[%s] failed: %v", pr.Number, g.repoOwner, g.repoName, remote, err)
513513
} else {

services/migrations/gitea_uploader.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ func (g *GiteaLocalUploader) updateGitForPullRequest(ctx context.Context, pr *ba
624624
remote = "head-pr-" + strconv.FormatInt(pr.Number, 10)
625625
}
626626
// ... now add the remote
627-
err := g.gitRepo.AddRemote(remote, pr.Head.CloneURL, true)
627+
err := g.gitRepo.AddRemote(ctx, remote, pr.Head.CloneURL, true)
628628
if err != nil {
629629
log.Error("PR #%d in %s/%s AddRemote[%s] failed: %v", pr.Number, g.repoOwner, g.repoName, remote, err)
630630
} else {

services/repository/branch.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ func RenameBranch(ctx context.Context, repo *repo_model.Repository, doer *user_m
442442
}
443443

444444
if err := git_model.RenameBranch(ctx, repo, from, to, func(ctx context.Context, isDefault bool) error {
445-
err2 := gitRepo.RenameBranch(from, to)
445+
err2 := gitRepo.RenameBranch(ctx, from, to)
446446
if err2 != nil {
447447
return err2
448448
}

services/wiki/wiki.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ func ChangeDefaultWikiBranch(ctx context.Context, repo *repo_model.Repository, n
397397
}
398398
defer gitRepo.Close()
399399

400-
err = gitRepo.RenameBranch(oldDefBranch, newBranch)
400+
err = gitRepo.RenameBranch(ctx, oldDefBranch, newBranch)
401401
if err != nil {
402402
return fmt.Errorf("unable to rename default branch: %w", err)
403403
}

0 commit comments

Comments
 (0)