Skip to content

Commit ac2f8c9

Browse files
authored
Reduce some allocations in type conversion (#26772)
1 parent 4803766 commit ac2f8c9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

modules/log/event_writer_base.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func (b *EventWriterBaseImpl) Run(ctx context.Context) {
9090

9191
if exprRegexp != nil {
9292
fileLineCaller := fmt.Sprintf("%s:%d:%s", event.Origin.Filename, event.Origin.Line, event.Origin.Caller)
93-
matched := exprRegexp.Match([]byte(fileLineCaller)) || exprRegexp.Match([]byte(event.Origin.MsgSimpleText))
93+
matched := exprRegexp.MatchString(fileLineCaller) || exprRegexp.MatchString(event.Origin.MsgSimpleText)
9494
if !matched {
9595
continue
9696
}

services/packages/rpm/repository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ func buildRepomd(pv *packages_model.PackageVersion, ownerID int64, data []*repoD
232232
}
233233

234234
var buf bytes.Buffer
235-
buf.Write([]byte(xml.Header))
235+
buf.WriteString(xml.Header)
236236
if err := xml.NewEncoder(&buf).Encode(&Repomd{
237237
Xmlns: "http://linux.duke.edu/metadata/repo",
238238
XmlnsRpm: "http://linux.duke.edu/metadata/rpm",

services/pull/pull.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -755,11 +755,11 @@ func GetSquashMergeCommitMessages(ctx context.Context, pr *issues_model.PullRequ
755755
}
756756

757757
for _, author := range authors {
758-
if _, err := stringBuilder.Write([]byte("Co-authored-by: ")); err != nil {
758+
if _, err := stringBuilder.WriteString("Co-authored-by: "); err != nil {
759759
log.Error("Unable to write to string builder Error: %v", err)
760760
return ""
761761
}
762-
if _, err := stringBuilder.Write([]byte(author)); err != nil {
762+
if _, err := stringBuilder.WriteString(author); err != nil {
763763
log.Error("Unable to write to string builder Error: %v", err)
764764
return ""
765765
}

0 commit comments

Comments
 (0)