Skip to content

Commit ac8bee6

Browse files
authored
Remove fomantic progress module (#19760)
Replace it with HTML `<progress>` element. The bar won't go green at 100% anymore but I think it's not something that fits stylistically anyways.
1 parent cc7236e commit ac8bee6

File tree

11 files changed

+37
-2035
lines changed

11 files changed

+37
-2035
lines changed

templates/repo/issue/milestones.tmpl

+7-4
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,13 @@
6161
<div class="milestone list">
6262
{{range .Milestones}}
6363
<li class="item">
64-
{{svg "octicon-milestone" 16 "mr-2"}} <a href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a>
65-
<div class="ui right green progress" data-percent="{{.Completeness}}">
66-
<div class="bar" {{if not .Completeness}}style="background-color: transparent"{{end}}>
67-
<div class="progress"></div>
64+
<div class="df ac sb">
65+
<h2 class="df ac m-0 fw">
66+
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a>
67+
</h2>
68+
<div class="df ac">
69+
<span class="mr-3">{{.Completeness}}%</span>
70+
<progress value="{{.Completeness}}" max="100"></progress>
6871
</div>
6972
</div>
7073
<div class="meta">

templates/shared/issuelist.tmpl

+2-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
{{if gt $tasks 0}}
7474
{{$tasksDone := .GetTasksDone}}
7575
<span class="checklist">
76-
{{svg "octicon-checklist" 14 "mr-2"}}{{$tasksDone}} / {{$tasks}} <span class="progress-bar"><span class="progress" style="width:calc(100% * {{$tasksDone}} / {{$tasks}});"></span></span>
76+
{{svg "octicon-checklist" 14 "mr-2"}}{{$tasksDone}} / {{$tasks}}
77+
<progress value="{{$tasksDone}}" max="{{$tasks}}"></progress>
7778
</span>
7879
{{end}}
7980
{{if ne .DeadlineUnix 0}}

templates/user/dashboard/milestones.tmpl

+8-5
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,14 @@
8080
<div class="milestone list">
8181
{{range .Milestones}}
8282
<li class="item">
83-
<div class="ui label">{{.Repo.FullName}}</div>
84-
{{svg "octicon-milestone"}} <a href="{{.Repo.Link }}/milestone/{{.ID}}">{{.Name}}</a>
85-
<div class="ui right green progress" data-percent="{{.Completeness}}">
86-
<div class="bar" {{if not .Completeness}}style="background-color: transparent"{{end}}>
87-
<div class="progress"></div>
83+
<div class="df ac sb">
84+
<h2 class="df ac m-0 fw">
85+
<span class="ui large label">{{.Repo.FullName}}</span>
86+
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{.Repo.Link}}/milestone/{{.ID}}">{{.Name}}</a>
87+
</h2>
88+
<div class="df ac">
89+
<span class="mr-3">{{.Completeness}}%</span>
90+
<progress value="{{.Completeness}}" max="100"></progress>
8891
</div>
8992
</div>
9093
<div class="meta">

0 commit comments

Comments
 (0)