Skip to content

Commit b0f1872

Browse files
wxiaoguanglunny
andauthored
Fix milestone title font problem (#22863)
Replace #22853 since it's closed, and actually there are 2 places need to be fixed. ~~Follow @fsologureng 's suggestion to keep the `<hX>` tags.~~ Update: from fsologureng: this doesn't change anything from a11y's point of view. So I think this PR could be fine to fix the UI looking problems as a quick patch, then defer the a11y problems to new PRs together. Before: the font-size is too large. After: it seems better. ![image](https://user-images.githubusercontent.com/2114189/218266257-fc2d5872-9e96-4c6a-87ea-f27531ac15c0.png) ![image](https://user-images.githubusercontent.com/2114189/218266247-efc09d83-405f-4495-967a-30d9744134ce.png) Co-authored-by: Lunny Xiao <[email protected]>
1 parent e460b6e commit b0f1872

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Diff for: templates/repo/issue/milestones.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@
6262
{{range .Milestones}}
6363
<li class="item">
6464
<div class="df ac sb">
65-
<h2 class="df ac m-0 fw">
65+
<h3 class="df ac m-0 fw">
6666
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{$.RepoLink}}/milestone/{{.ID}}">{{.Name}}</a>
67-
</h2>
67+
</h3>
6868
<div class="df ac">
6969
<span class="mr-3">{{.Completeness}}%</span>
7070
<progress value="{{.Completeness}}" max="100"></progress>

Diff for: templates/user/dashboard/milestones.tmpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@
8181
{{range .Milestones}}
8282
<li class="item">
8383
<div class="df ac sb">
84-
<h2 class="df ac m-0 fw">
84+
<h3 class="df ac m-0 fw">
8585
<span class="ui large label">{{.Repo.FullName}}</span>
8686
{{svg "octicon-milestone" 16 "mr-3"}}<a class="muted" href="{{.Repo.Link}}/milestone/{{.ID}}">{{.Name}}</a>
87-
</h2>
87+
</h3>
8888
<div class="df ac">
8989
<span class="mr-3">{{.Completeness}}%</span>
9090
<progress value="{{.Completeness}}" max="100"></progress>

0 commit comments

Comments
 (0)